feat(ramp): add buy and sell icon and string #20891

wachunei · 2023-09-14T16:29:42Z

Explanation

This PR changes the icon and text for the portfolio ramp experience from "Buy" to "Buy & Sell".

Screenshots/Screencaps

Before

Asset View

Action Modal

After

Asset View

Action Modal

Manual Testing Steps

Clicking on the Buy & Sell button should not change behavior and take the user to the portfolio buy experience.

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

codecov · 2023-09-15T00:31:13Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (78e5863) 68.40% compared to head (f8750e3) 68.40%.
Report is 28 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #20891   +/-   ##
========================================
  Coverage    68.40%   68.40%           
========================================
  Files         1008     1008           
  Lines        40301    40301           
  Branches     10778    10778           
========================================
+ Hits         27565    27566    +1     
+ Misses       12736    12735    -1

Files	Coverage Δ
ui/components/app/wallet-overview/eth-overview.js	`81.33% <ø> (ø)`
...i/components/app/wallet-overview/token-overview.js	`63.64% <ø> (ø)`
...tichain/select-action-modal/select-action-modal.js	`60.00% <ø> (ø)`
ui/hooks/experiences/useRamps.ts	`100.00% <100.00%> (ø)`

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-09-15T00:41:01Z

Builds ready [f935224]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1483 ± 32 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	145	126	11	5
		domContentLoaded	1322	1627	1483	67	32
		load	1322	1627	1483	67	32
		domInteractive	1322	1627	1483	67	32

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 51 Bytes (0.00%)
common: 34 Bytes (0.00%)

metamaskbot · 2023-09-15T14:55:31Z

Builds ready [f71710d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1527 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	174	126	15	7
		domContentLoaded	1396	1884	1527	125	60
		load	1396	1884	1527	125	60
		domInteractive	1396	1884	1527	125	60

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 56 Bytes (0.00%)
common: 34 Bytes (0.00%)

metamaskbot · 2023-09-25T17:26:10Z

Builds ready [ef0995d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1669 ± 48 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	157	112	21	10
		domContentLoaded	76	156	107	20	10
		load	1479	1885	1669	100	48
		domInteractive	76	156	107	20	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 56 Bytes (0.00%)
common: 34 Bytes (0.00%)

metamaskbot · 2023-09-26T19:13:18Z

Builds ready [afdc07b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1097 ± 354 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	83	144	104	18	9
		domContentLoaded	67	138	97	17	8
		load	81	1862	1097	737	354
		domInteractive	67	138	97	17	8

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 56 Bytes (0.00%)
common: 34 Bytes (0.00%)

app/_locales/en/messages.json

metamaskbot · 2023-09-27T17:45:47Z

Builds ready [c0518b8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (882 ± 374 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	173	113	19	9
		domContentLoaded	69	163	102	19	9
		load	80	1894	882	779	374
		domInteractive	69	163	102	19	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 83 Bytes (0.00%)
common: 28 Bytes (0.00%)

metamaskbot · 2023-09-27T19:34:58Z

Builds ready [f8750e3]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (658 ± 337 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	80	122	91	11	5
		domContentLoaded	68	119	81	15	7
		load	79	1583	658	703	337
		domInteractive	68	119	81	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 83 Bytes (0.00%)
common: 28 Bytes (0.00%)

wachunei added 4 commits September 10, 2023 22:27

feat(ramp): add buy and sell icon and string

ddfe838

feat(ramp): add buy and sell icon to token overview

a17891e

Merge branch 'develop' into feat/ramp-buy-sell-button

eca2be2

Merge branch 'develop' into feat/ramp-buy-sell-button

f935224

wachunei added the team-ramp label Sep 14, 2023

feat(ramp): add sell to metamask entry query param

f71710d

wachunei force-pushed the feat/ramp-buy-sell-button branch from 1e785e3 to f71710d Compare September 15, 2023 14:21

wachunei marked this pull request as ready for review September 15, 2023 15:00

wachunei requested a review from a team as a code owner September 15, 2023 15:00

wachunei added 2 commits September 24, 2023 08:15

Merge branch 'develop' into feat/ramp-buy-sell-button

ce2113f

Merge branch 'develop' into feat/ramp-buy-sell-button

ef0995d

wachunei added 2 commits September 26, 2023 11:34

Merge branch 'develop' into feat/ramp-buy-sell-button

fa2ba66

Merge branch 'develop' into feat/ramp-buy-sell-button

afdc07b

darkwing previously approved these changes Sep 26, 2023

View reviewed changes

kevinghim added the needs-ux-ds-review label Sep 26, 2023

DDDDDanica reviewed Sep 27, 2023

View reviewed changes

app/_locales/en/messages.json Outdated Show resolved Hide resolved

app/_locales/en/messages.json Show resolved Hide resolved

Merge branch 'develop' into feat/ramp-buy-sell-button

c23de62

wachunei dismissed darkwing’s stale review via c23de62 September 27, 2023 16:17

wachunei added 3 commits September 27, 2023 10:32

feat(ramp): add buy and sell butotn to action modal

16f95de

test(ramp): update for buy and sell button in action modal

170cd36

chore(ramp): remove unused locale messages

c0518b8

darkwing approved these changes Sep 27, 2023

View reviewed changes

Merge branch 'develop' into feat/ramp-buy-sell-button

f8750e3

DDDDDanica approved these changes Sep 28, 2023

View reviewed changes

wachunei merged commit f860685 into develop Sep 28, 2023
9 checks passed

wachunei deleted the feat/ramp-buy-sell-button branch September 28, 2023 16:02

github-actions bot locked and limited conversation to collaborators Sep 28, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ramp): add buy and sell icon and string #20891

feat(ramp): add buy and sell icon and string #20891

wachunei commented Sep 14, 2023 •

edited

Loading

codecov bot commented Sep 15, 2023 •

edited

Loading

metamaskbot commented Sep 15, 2023

metamaskbot commented Sep 15, 2023

metamaskbot commented Sep 25, 2023

metamaskbot commented Sep 26, 2023

metamaskbot commented Sep 27, 2023

metamaskbot commented Sep 27, 2023

feat(ramp): add buy and sell icon and string #20891

feat(ramp): add buy and sell icon and string #20891

Conversation

wachunei commented Sep 14, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Before

Asset View

Action Modal

After

Asset View

Action Modal

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

codecov bot commented Sep 15, 2023 • edited Loading

Codecov Report

metamaskbot commented Sep 15, 2023

metamaskbot commented Sep 15, 2023

metamaskbot commented Sep 25, 2023

metamaskbot commented Sep 26, 2023

metamaskbot commented Sep 27, 2023

metamaskbot commented Sep 27, 2023

wachunei commented Sep 14, 2023 •

edited

Loading

codecov bot commented Sep 15, 2023 •

edited

Loading