Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cancel transaction.csv #20881

Merged
merged 5 commits into from
Sep 22, 2023
Merged

Update cancel transaction.csv #20881

merged 5 commits into from
Sep 22, 2023

Conversation

benjisclowder
Copy link
Contributor

Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item.

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item.
@benjisclowder benjisclowder added area-documentation Issues relating to documentation, in the codebase and off. team-extension-platform labels Sep 14, 2023
@benjisclowder benjisclowder requested a review from a team as a code owner September 14, 2023 10:58
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b4951ba]
Page Load Metrics (1605 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1122441423517
domContentLoaded13591995160520096
load13591995160520096
domInteractive13591995160520096
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (df327a4) 68.25% compared to head (b4951ba) 68.24%.

❗ Current head b4951ba differs from pull request most recent head 031b2ed. Consider uploading reports for the commit 031b2ed to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20881      +/-   ##
===========================================
- Coverage    68.25%   68.24%   -0.01%     
===========================================
  Files         1006     1006              
  Lines        40190    40184       -6     
  Branches     10744    10742       -2     
===========================================
- Hits         27430    27423       -7     
- Misses       12760    12761       +1     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [031b2ed]
Page Load Metrics (1643 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint123174143157
domContentLoaded14332209164318187
load14332210164318187
domInteractive14332209164318187
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@DDDDDanica DDDDDanica merged commit f690d9a into develop Sep 22, 2023
9 checks passed
@DDDDDanica DDDDDanica deleted the benjisclowder-patch-5 branch September 22, 2023 19:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-documentation Issues relating to documentation, in the codebase and off. release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants