-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update send erc20 token origin MM.csv #20878
Conversation
Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item, in the next step.
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [76874f0]
Page Load Metrics (1815 ± 81 ms)
Bundle size diffs
|
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #20878 +/- ##
========================================
Coverage 68.34% 68.34%
========================================
Files 1007 1007
Lines 40254 40254
Branches 10761 10761
========================================
Hits 27508 27508
Misses 12746 12746 ☔ View full report in Codecov by Sentry. |
Builds ready [f1d6f15]
Page Load Metrics (1544 ± 31 ms)
Bundle size diffs
|
Builds ready [4a4fe35]
Page Load Metrics (1645 ± 78 ms)
Bundle size diffs
|
Builds ready [82beaf7]
Page Load Metrics (1581 ± 44 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :D
Builds ready [6ee1dbf]
Page Load Metrics (1642 ± 64 ms)
Bundle size diffs
|
Deleting line "The recipient's hexadecimal address is shown in the activity list item." as the hexadecimal address is not supposed to be shown in the activity list item unless you open the activity list item, in the next step.
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.