-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MMI] Deletes unnecessary logic for mmi #20834
Merged
zone-live
merged 5 commits into
develop
from
MMI-3745-remove-set-dashboard-cookie-in-extension
Oct 2, 2023
Merged
[MMI] Deletes unnecessary logic for mmi #20834
zone-live
merged 5 commits into
develop
from
MMI-3745-remove-set-dashboard-cookie-in-extension
Oct 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…ithub.com:MetaMask/metamask-extension into MMI-3745-remove-set-dashboard-cookie-in-extension
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #20834 +/- ##
===========================================
+ Coverage 68.49% 68.52% +0.03%
===========================================
Files 1012 1011 -1
Lines 40588 40540 -48
Branches 10843 10832 -11
===========================================
- Hits 27799 27779 -20
+ Misses 12789 12761 -28
☔ View full report in Codecov by Sentry. |
Builds ready [ab9b9d3]
Page Load Metrics (1255 ± 364 ms)
Bundle size diffs
|
albertolive
approved these changes
Oct 2, 2023
brad-decker
approved these changes
Oct 2, 2023
zone-live
deleted the
MMI-3745-remove-set-dashboard-cookie-in-extension
branch
October 2, 2023 17:31
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Oct 2, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-mmi
PRs from the MMI team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
MMI no longer needs this bit of logic 🧹
Pre-merge author checklist