Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MMI] Deletes unnecessary logic for mmi #20834

Merged

Conversation

zone-live
Copy link
Contributor

Explanation

MMI no longer needs this bit of logic 🧹

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added the team-mmi PRs from the MMI team label Sep 21, 2023
@zone-live zone-live marked this pull request as ready for review October 2, 2023 13:30
@zone-live zone-live requested a review from a team as a code owner October 2, 2023 13:30
zone-live and others added 3 commits October 2, 2023 14:30
…ithub.com:MetaMask/metamask-extension into MMI-3745-remove-set-dashboard-cookie-in-extension
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0107c2c) 68.49% compared to head (ab9b9d3) 68.52%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #20834      +/-   ##
===========================================
+ Coverage    68.49%   68.52%   +0.03%     
===========================================
  Files         1012     1011       -1     
  Lines        40588    40540      -48     
  Branches     10843    10832      -11     
===========================================
- Hits         27799    27779      -20     
+ Misses       12789    12761      -28     
Files Coverage Δ
app/scripts/controllers/mmi-controller.js 15.00% <100.00%> (-2.39%) ⬇️
...cripts/lib/rpc-method-middleware/handlers/index.js 100.00% <ø> (ø)
app/scripts/metamask-controller.js 53.88% <ø> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [ab9b9d3]
Page Load Metrics (1255 ± 364 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint81131102157
domContentLoaded7514597199
load8919401255759364
domInteractive7514597199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 04aae35 into develop Oct 2, 2023
9 checks passed
@zone-live zone-live deleted the MMI-3745-remove-set-dashboard-cookie-in-extension branch October 2, 2023 17:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Oct 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-mmi PRs from the MMI team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants