Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the user the ability to opt out of 3rd party network validation when adding a new network #20816

Merged
merged 22 commits into from
Sep 28, 2023

Conversation

pedronfigueiredo
Copy link
Contributor

Explanation

This PR gives the user control over the privacy settings for enabling or disabling a call to https://chainid.network/chains.json.

This is achieved by adding the toggle to the preferences controller and the condition in the appropriate place.

Integration tests are included.

Screenshots/Screencaps

[insert screenshot from test]

Manual Testing Steps

  • Go to the privacy settings screen
  • Disable validation
  • Validate (in the network tab on dev tools) that the request is not made.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@pedronfigueiredo pedronfigueiredo added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Sep 11, 2023
@pedronfigueiredo pedronfigueiredo self-assigned this Sep 11, 2023
@pedronfigueiredo pedronfigueiredo changed the title Opt out of Network Validation Give the user ability to opt out of Network Validation Sep 11, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@pedronfigueiredo pedronfigueiredo changed the title Give the user ability to opt out of Network Validation Give the user ability to opt out of 3rd party network validation when adding a new network Sep 11, 2023
@gauthierpetetin gauthierpetetin added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 11, 2023
@pedronfigueiredo pedronfigueiredo changed the title Give the user ability to opt out of 3rd party network validation when adding a new network Give the user the ability to opt out of 3rd party network validation when adding a new network Sep 11, 2023
@pedronfigueiredo pedronfigueiredo force-pushed the feat/876-opt-out-network-validation branch from 044d166 to 5f14753 Compare September 11, 2023 17:17
@pedronfigueiredo pedronfigueiredo marked this pull request as ready for review September 11, 2023 17:17
@pedronfigueiredo pedronfigueiredo requested a review from a team as a code owner September 11, 2023 17:17
@pedronfigueiredo pedronfigueiredo force-pushed the feat/876-opt-out-network-validation branch from 5f14753 to 06ff71a Compare September 12, 2023 11:05
test/e2e/helpers.js Outdated Show resolved Hide resolved
test/e2e/tests/add-custom-network.spec.js Outdated Show resolved Hide resolved
test/e2e/tests/add-custom-network.spec.js Outdated Show resolved Hide resolved
ui/pages/settings/security-tab/security-tab.component.js Outdated Show resolved Hide resolved
ui/pages/settings/security-tab/security-tab.component.js Outdated Show resolved Hide resolved
@pedronfigueiredo pedronfigueiredo force-pushed the feat/876-opt-out-network-validation branch from 9335de4 to 0727667 Compare September 14, 2023 13:06
@pedronfigueiredo pedronfigueiredo force-pushed the feat/876-opt-out-network-validation branch 2 times, most recently from 347b547 to f4b57be Compare September 14, 2023 13:50
DDDDDanica
DDDDDanica previously approved these changes Sep 14, 2023
@pedronfigueiredo pedronfigueiredo added release-blocker This bug is blocking the next release team-extension-platform and removed release-blocker This bug is blocking the next release team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Sep 18, 2023
@pedronfigueiredo pedronfigueiredo force-pushed the feat/876-opt-out-network-validation branch from f4b57be to 5a477b5 Compare September 18, 2023 11:39
DDDDDanica
DDDDDanica previously approved these changes Sep 18, 2023
@pedronfigueiredo pedronfigueiredo force-pushed the feat/876-opt-out-network-validation branch from a6f481c to 779a6cd Compare September 28, 2023 07:54
@metamaskbot
Copy link
Collaborator

Builds ready [779a6cd]
Page Load Metrics (1043 ± 371 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87153103157
domContentLoaded6912294136
load8018281043773371
domInteractive6912294136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 224 Bytes (0.01%)
  • ui: 2.08 KiB (0.03%)
  • common: 610 Bytes (0.01%)

@pedronfigueiredo pedronfigueiredo merged commit 22fe040 into develop Sep 28, 2023
9 checks passed
@pedronfigueiredo pedronfigueiredo deleted the feat/876-opt-out-network-validation branch September 28, 2023 09:38
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2023
@metamaskbot metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.3.0 Issue or pull request that will be included in release 11.3.0 team-extension-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants