-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give the user the ability to opt out of 3rd party network validation when adding a new network #20816
Merged
pedronfigueiredo
merged 22 commits into
develop
from
feat/876-opt-out-network-validation
Sep 28, 2023
Merged
Give the user the ability to opt out of 3rd party network validation when adding a new network #20816
pedronfigueiredo
merged 22 commits into
develop
from
feat/876-opt-out-network-validation
Sep 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronfigueiredo
added
team-extension-client
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
labels
Sep 11, 2023
pedronfigueiredo
changed the title
Opt out of Network Validation
Give the user ability to opt out of Network Validation
Sep 11, 2023
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
changed the title
Give the user ability to opt out of Network Validation
Give the user ability to opt out of 3rd party network validation when adding a new network
Sep 11, 2023
gauthierpetetin
added
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 11, 2023
pedronfigueiredo
changed the title
Give the user ability to opt out of 3rd party network validation when adding a new network
Give the user the ability to opt out of 3rd party network validation when adding a new network
Sep 11, 2023
pedronfigueiredo
force-pushed
the
feat/876-opt-out-network-validation
branch
from
September 11, 2023 17:17
044d166
to
5f14753
Compare
legobeat
reviewed
Sep 12, 2023
legobeat
reviewed
Sep 12, 2023
pedronfigueiredo
force-pushed
the
feat/876-opt-out-network-validation
branch
from
September 12, 2023 11:05
5f14753
to
06ff71a
Compare
DDDDDanica
reviewed
Sep 12, 2023
pedronfigueiredo
force-pushed
the
feat/876-opt-out-network-validation
branch
from
September 14, 2023 13:06
9335de4
to
0727667
Compare
pedronfigueiredo
force-pushed
the
feat/876-opt-out-network-validation
branch
2 times, most recently
from
September 14, 2023 13:50
347b547
to
f4b57be
Compare
DDDDDanica
previously approved these changes
Sep 14, 2023
pedronfigueiredo
added
release-blocker
This bug is blocking the next release
team-extension-platform
and removed
release-blocker
This bug is blocking the next release
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
labels
Sep 18, 2023
pedronfigueiredo
force-pushed
the
feat/876-opt-out-network-validation
branch
from
September 18, 2023 11:39
f4b57be
to
5a477b5
Compare
DDDDDanica
previously approved these changes
Sep 18, 2023
pedronfigueiredo
force-pushed
the
feat/876-opt-out-network-validation
branch
from
September 20, 2023 12:50
ef37b9e
to
2cc242a
Compare
pedronfigueiredo
force-pushed
the
feat/876-opt-out-network-validation
branch
from
September 28, 2023 07:54
a6f481c
to
779a6cd
Compare
albertolive
approved these changes
Sep 28, 2023
Builds ready [779a6cd]
Page Load Metrics (1043 ± 371 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
github-actions
bot
removed
the
needs-dev-review
PR needs reviews from other engineers (in order to receive required approvals)
label
Sep 28, 2023
metamaskbot
added
the
release-11.3.0
Issue or pull request that will be included in release 11.3.0
label
Sep 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.3.0
Issue or pull request that will be included in release 11.3.0
team-extension-platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR gives the user control over the privacy settings for enabling or disabling a call to
https://chainid.network/chains.json
.This is achieved by adding the toggle to the preferences controller and the condition in the appropriate place.
Integration tests are included.
Screenshots/Screencaps
[insert screenshot from test]
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist