Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CircleCI is now storing builds-test and builds-test-flask #20749

Merged
merged 5 commits into from
Sep 26, 2023
Merged

feat: CircleCI is now storing builds-test and builds-test-flask #20749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1317239
feat: CircleCI is now storing test builds and test-flask builds
HowardBraham Sep 6, 2023
213396b
storing earlier
HowardBraham Sep 6, 2023
364d06e
using the CircleCI cache to move data between jobs that aren't `requi…
HowardBraham Sep 12, 2023
1705077
trying with CIRCLE_SHA1 to support "Rerun workflow from failed"
HowardBraham Sep 14, 2023
b8d9fa4
no longer need the save_cache stuff
HowardBraham Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,10 +568,10 @@ jobs:
name: Build extension for testing
command: yarn build:test:flask
- run:
name: Move test build to 'dist-test' to avoid conflict with production build
name: Move test build to 'dist-test-flask' to avoid conflict with production build
command: mv ./dist ./dist-test-flask
- run:
name: Move test zips to 'builds-test' to avoid conflict with production build
name: Move test zips to 'builds-test-flask' to avoid conflict with production build
command: mv ./builds ./builds-test-flask
- persist_to_workspace:
root: .
Expand All @@ -592,7 +592,7 @@ jobs:
name: Move test build to 'dist-test' to avoid conflict with production build
command: mv ./dist ./dist-test-mv3
- run:
name: Move test zips to 'builds-test' to avoid conflict with production build
name: Move test zips to 'builds-test-mv3' to avoid conflict with production build
command: mv ./builds ./builds-test-mv3
- persist_to_workspace:
root: .
Expand Down Expand Up @@ -1162,6 +1162,10 @@ jobs:
- store_artifacts:
path: builds-mmi
destination: builds-mmi
- store_artifacts:
path: builds-test
- store_artifacts:
path: builds-test-flask
- store_artifacts:
path: coverage
destination: coverage
Expand Down
28 changes: 23 additions & 5 deletions development/metamaskbot-build-announce.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,19 @@ function getPercentageChange(from, to) {
}

async function start() {
const { GITHUB_COMMENT_TOKEN, CIRCLE_PULL_REQUEST } = process.env;
const {
GITHUB_COMMENT_TOKEN,
CIRCLE_PULL_REQUEST,
CIRCLE_SHA1,
CIRCLE_BUILD_NUM,
CIRCLE_WORKFLOW_JOB_ID,
PARENT_COMMIT,
} = process.env;

console.log('CIRCLE_PULL_REQUEST', CIRCLE_PULL_REQUEST);
const { CIRCLE_SHA1 } = process.env;
console.log('CIRCLE_SHA1', CIRCLE_SHA1);
const { CIRCLE_BUILD_NUM } = process.env;
console.log('CIRCLE_BUILD_NUM', CIRCLE_BUILD_NUM);
const { CIRCLE_WORKFLOW_JOB_ID } = process.env;
console.log('CIRCLE_WORKFLOW_JOB_ID', CIRCLE_WORKFLOW_JOB_ID);
const { PARENT_COMMIT } = process.env;
console.log('PARENT_COMMIT', PARENT_COMMIT);

if (!CIRCLE_PULL_REQUEST) {
Expand Down Expand Up @@ -81,6 +85,18 @@ async function start() {
return `<a href="${url}">${platform}</a>`;
})
.join(', ');
const testBuildLinks = platforms
.map((platform) => {
const url = `${BUILD_LINK_BASE}/builds-test/metamask-${platform}-${VERSION}.zip`;
return `<a href="${url}">${platform}</a>`;
})
.join(', ');
const testFlaskBuildLinks = platforms
.map((platform) => {
const url = `${BUILD_LINK_BASE}/builds-test-flask/metamask-flask-${platform}-${VERSION}-flask.0.zip`;
return `<a href="${url}">${platform}</a>`;
})
.join(', ');

// links to bundle browser builds
const bundles = {};
Expand Down Expand Up @@ -147,6 +163,8 @@ async function start() {
`builds (beta): ${betaBuildLinks}`,
`builds (flask): ${flaskBuildLinks}`,
`builds (MMI): ${mmiBuildLinks}`,
`builds (test): ${testBuildLinks}`,
`builds (test-flask): ${testFlaskBuildLinks}`,
`build viz: ${depVizLink}`,
`mv3: ${moduleInitStatsBackgroundLink}`,
`mv3: ${moduleInitStatsUILink}`,
Expand Down
Loading