fix: rename anonymous transaction events. #20736

segun · 2023-09-05T14:19:04Z

Explanation

Currently anonymous and non-anonymous events share the same name. This creates confusion on data analysis done by stakeholders and blocks some of the automations and improvements that are being done by the data team. In order to improve this, we should rename the anonymous transactions events in MM to a different name so they can be easily identified and treated differently from the non-anonymous ones.

Acceptance Criterias

anonymous Transaction Added event is renamed to Transaction Added Anon
anonymous Transaction Approved event is renamed to Transaction Approved Anon
anonymous Transaction Rejected event is renamed to Transaction Rejected Anon
anonymous Transaction Submitted event is renamed to Transaction Submitted Anon
anonymous Transaction Finalized event is renamed to Transaction Finalized Anon
No change is made to non-anonymous transactions events
Transaction Added Anon, Transaction Approved Anon, Transaction Rejected Anon, Transaction Submitted Anon, Transaction Finalized Anon are added to the transactions events documentation in segment-schema

Fixes Issue

Manual Testing Steps

launch Metamask
open test-dapp
do a send transaction
cancel it
do another send transaction
confirm it
check mix panel and see that Anonymous Transaction events now have Anon appended to the event names

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

github-actions · 2023-09-05T14:19:18Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2023-09-13T14:12:43Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (d1310d9) 68.42% compared to head (d27b4f0) 68.43%.
Report is 2 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #20736      +/-   ##
===========================================
+ Coverage    68.42%   68.43%   +0.01%     
===========================================
  Files         1008     1008              
  Lines        40321    40333      +12     
  Branches     10783    10785       +2     
===========================================
+ Hits         27589    27601      +12     
  Misses       12732    12732

Files	Coverage Δ
shared/constants/transaction.ts	`100.00% <100.00%> (ø)`
app/scripts/controllers/metametrics.js	`80.19% <77.78%> (+0.39%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-09-13T14:22:50Z

Builds ready [7320552]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1672 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	115	224	144	26	13
		domContentLoaded	1438	2207	1672	167	80
		load	1439	2207	1672	167	80
		domInteractive	1438	2207	1672	167	80

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 701 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 305 Bytes (0.01%)

jpuri · 2023-09-13T15:42:42Z

test/e2e/helpers.js

    for (const mockedEndpoint of mockedEndpoints) {
      isPending = await mockedEndpoint.isPending();
    }

    return isPending === !hasRequest;
-  }, driver.timeout);
+  }, 100000);


May be rather change driver.timeout, if this change is required.

test/e2e/metrics/transaction-finalized.spec.js

app/scripts/controllers/metametrics.js

metamaskbot · 2023-09-13T23:41:46Z

Builds ready [450f6ad]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1651 ± 33 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	116	191	143	22	11
		domContentLoaded	1514	1791	1651	69	33
		load	1515	1791	1651	69	33
		domInteractive	1514	1791	1651	69	33

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 701 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 305 Bytes (0.01%)

app/scripts/controllers/metametrics.test.js

Signed-off-by: Olusegun Akintayo <[email protected]>

…ment.

Signed-off-by: Akintayo A. Olusegun <[email protected]>

Signed-off-by: Olusegun Akintayo <[email protected]>

metamaskbot · 2023-09-28T13:15:46Z

Builds ready [d27b4f0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1006 ± 433 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	177	124	25	12
		domContentLoaded	73	172	110	21	10
		load	85	2384	1006	902	433
		domInteractive	73	172	110	21	10

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 701 Bytes (0.02%)
ui: 0 Bytes (0.00%)
common: 305 Bytes (0.01%)

metamaskbot · 2023-09-28T13:16:09Z

Builds ready [2491ad6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1256 ± 496 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	86	226	134	30	14
		domContentLoaded	70	153	119	22	11
		load	81	2425	1256	1033	496
		domInteractive	70	152	119	22	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 701 Bytes (0.02%)
ui: 99 Bytes (0.00%)
common: 305 Bytes (0.01%)

segun requested a review from a team as a code owner September 5, 2023 14:19

segun self-assigned this Sep 5, 2023

segun changed the title ~~rename anonymous transaction events.~~ fix: rename anonymous transaction events. Sep 5, 2023

segun force-pushed the olu/rename-anon-tx-events branch from 6278285 to e6e33a4 Compare September 5, 2023 14:20

segun added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Sep 5, 2023

segun force-pushed the olu/rename-anon-tx-events branch 3 times, most recently from fde949e to 7320552 Compare September 13, 2023 13:47

jpuri reviewed Sep 13, 2023

View reviewed changes

test/e2e/metrics/transaction-finalized.spec.js Show resolved Hide resolved

jpuri reviewed Sep 13, 2023

View reviewed changes

app/scripts/controllers/metametrics.js Show resolved Hide resolved

blackdevelopa reviewed Sep 14, 2023

View reviewed changes

app/scripts/controllers/metametrics.test.js Show resolved Hide resolved

segun added 6 commits September 25, 2023 11:56

rename anonymous transaction events.

2236e57

Signed-off-by: Olusegun Akintayo <[email protected]>

If event name is not replace-able, use the name, else use the replace…

412655f

…ment.

Add Anon to anonymous events in e2e

5dd0e40

Signed-off-by: Akintayo A. Olusegun <[email protected]>

Remove console log

c2d7686

Signed-off-by: Olusegun Akintayo <[email protected]>

remove manual timeouts

54e54a2

Tests for Anon Transaction events.

969beae

Signed-off-by: Olusegun Akintayo <[email protected]>

segun force-pushed the olu/rename-anon-tx-events branch from 07788c6 to 969beae Compare September 25, 2023 10:58

brad-decker approved these changes Sep 26, 2023

View reviewed changes

blackdevelopa approved these changes Sep 27, 2023

View reviewed changes

segun added 2 commits September 28, 2023 13:07

Merge branch 'develop' into olu/rename-anon-tx-events

2491ad6

Merge branch 'develop' into olu/rename-anon-tx-events

d27b4f0

segun merged commit 03b2a23 into develop Sep 28, 2023
9 checks passed

segun deleted the olu/rename-anon-tx-events branch September 28, 2023 13:45

github-actions bot locked and limited conversation to collaborators Sep 28, 2023

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 28, 2023

metamaskbot added the release-11.3.0 Issue or pull request that will be included in release 11.3.0 label Sep 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: rename anonymous transaction events. #20736

fix: rename anonymous transaction events. #20736

segun commented Sep 5, 2023 •

edited

Loading

github-actions bot commented Sep 5, 2023

codecov bot commented Sep 13, 2023 •

edited

Loading

metamaskbot commented Sep 13, 2023

jpuri Sep 13, 2023

metamaskbot commented Sep 13, 2023

metamaskbot commented Sep 28, 2023

metamaskbot commented Sep 28, 2023

fix: rename anonymous transaction events. #20736

fix: rename anonymous transaction events. #20736

Conversation

segun commented Sep 5, 2023 • edited Loading

Explanation

Acceptance Criterias

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 5, 2023

codecov bot commented Sep 13, 2023 • edited Loading

Codecov Report

metamaskbot commented Sep 13, 2023

jpuri Sep 13, 2023

Choose a reason for hiding this comment

metamaskbot commented Sep 13, 2023

metamaskbot commented Sep 28, 2023

metamaskbot commented Sep 28, 2023

segun commented Sep 5, 2023 •

edited

Loading

codecov bot commented Sep 13, 2023 •

edited

Loading