feat(templates): new templates for issues and PRs #20651
Merged
+252
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
DDDDDanica
reviewed
Aug 30, 2023
|
Thanks a lot for the review @DDDDDanica 🙏 |
Builds ready [725877d]
Page Load Metrics (1514 ± 23 ms)
Bundle size diffs
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #20651 +/- ##
========================================
Coverage 68.17% 68.17%
========================================
Files 998 998
Lines 39966 39966
Branches 10686 10686
========================================
Hits 27243 27243
Misses 12723 12723 ☔ View full report in Codecov by Sentry. |
Builds ready [9bf595d]
Page Load Metrics (1570 ± 51 ms)
Bundle size diffs
|
Builds ready [984f39b]
Page Load Metrics (1590 ± 40 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Looking good! Some suggestions based on the specifics of the extension and removing references to React Native which is only used in mobile. We could also utilize the contributor docs that the Shared Libraries team is working on. I've suggested a couple places to link out to but there may be some more oppurtunities https://github.com/MetaMask/contributor-docs cc @mcmire @desi @Gudahtt
legobeat
reviewed
Sep 15, 2023
We've discussed with stakeholders from Extension and Mobile teams how we could align templates for issues and PRs on the different repos, starting with metamask-extension and metamask-mobile repos. This is the proposal we landed on after our first workshops.
This change was suggested by Nicolas Massart.
This change was suggested by Nicolas Massart.
…ifferent in extension
Comment from George Marshall: Because we use kebab-case for file names but retain PascalCase for component and enum names it may make sense to reword this sentence
gauthierpetetin
force-pushed
the
feat/pr-and-issues-templates
branch
from
984f39b to
4cf13dd
Compare
pedronfigueiredo
approved these changes
Sep 18, 2023
DDDDDanica
approved these changes
Sep 18, 2023
Builds ready [4cf13dd]
Page Load Metrics (1397 ± 30 ms)
Bundle size diffs
|
metamaskbot
added
the
release-11.3.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've discussed with stakeholders from Extension and Mobile teams how we could align templates for issues and PRs on the different repos, starting with metamask-extension and metamask-mobile repos. This is the proposal we landed on after our first workshops.
Screenshots/Recordings
Templates can be visualised on this test repo:
Issue
NA
References