Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update snaps-related copy #20601

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Update snaps-related copy #20601

merged 2 commits into from
Aug 25, 2023

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Aug 25, 2023

Explanation

Closes MetaMask/snaps#1689.
Closes MetaMask/snaps#1688.

This fixes some snaps related copy in two places.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@Mrtenz Mrtenz added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Aug 25, 2023
@Mrtenz Mrtenz requested a review from a team as a code owner August 25, 2023 09:29
david0xd
david0xd previously approved these changes Aug 25, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [95510b2]
Page Load Metrics (1623 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint117169136147
domContentLoaded1481180216238943
load1481180316238943
domInteractive1481180216238943
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 51 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #20601 (95510b2) into develop (d76b458) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20601   +/-   ##
========================================
  Coverage    68.86%   68.86%           
========================================
  Files          989      989           
  Lines        38697    38697           
  Branches     10376    10376           
========================================
  Hits         26647    26647           
  Misses       12050    12050           

@Mrtenz Mrtenz merged commit f8a7a83 into develop Aug 25, 2023
@Mrtenz Mrtenz deleted the mrtenz/snaps-copy branch August 25, 2023 10:40
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2023
@metamaskbot metamaskbot added the release-11.1.0 Issue or pull request that will be included in release 11.1.0 label Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update copy of empty notifications menu Update copy of empty snaps menu
5 participants