Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update derivation paths used by snaps #20558

Merged
merged 2 commits into from
Aug 23, 2023
Merged

Conversation

FrederikBolding
Copy link
Member

Explanation

Updates the hardcoded derivation paths used in snaps.

@FrederikBolding FrederikBolding added the team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead label Aug 23, 2023
@FrederikBolding FrederikBolding requested a review from a team as a code owner August 23, 2023 10:24
GuillaumeRx
GuillaumeRx previously approved these changes Aug 23, 2023
david0xd
david0xd previously approved these changes Aug 23, 2023
legobeat
legobeat previously approved these changes Aug 23, 2023
Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metamaskbot
Copy link
Collaborator

Builds ready [eaadbf9]
Page Load Metrics (1657 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint112177143199
domContentLoaded14732028165714369
load14732028165714369
domInteractive14722028165714369
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 200 Bytes (0.00%)

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #20558 (eaadbf9) into develop (d3d30fd) will not change coverage.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20558   +/-   ##
========================================
  Coverage    69.10%   69.10%           
========================================
  Files          995      995           
  Lines        38638    38638           
  Branches     10370    10370           
========================================
  Hits         26699    26699           
  Misses       11939    11939           

@FrederikBolding FrederikBolding merged commit 3f24662 into develop Aug 23, 2023
@FrederikBolding FrederikBolding deleted the fb/update-snap-dpaths branch August 23, 2023 12:29
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2023
@metamaskbot metamaskbot added the release-11.1.0 Issue or pull request that will be included in release 11.1.0 label Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.1.0 Issue or pull request that will be included in release 11.1.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants