-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update derivation paths used by snaps #20558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
added
the
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
label
Aug 23, 2023
GuillaumeRx
previously approved these changes
Aug 23, 2023
david0xd
previously approved these changes
Aug 23, 2023
legobeat
previously approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
FrederikBolding
dismissed stale reviews from legobeat, david0xd, and GuillaumeRx
via
August 23, 2023 11:14
eaadbf9
GuillaumeRx
approved these changes
Aug 23, 2023
david0xd
approved these changes
Aug 23, 2023
Builds ready [eaadbf9]
Page Load Metrics (1657 ± 69 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov Report
@@ Coverage Diff @@
## develop #20558 +/- ##
========================================
Coverage 69.10% 69.10%
========================================
Files 995 995
Lines 38638 38638
Branches 10370 10370
========================================
Hits 26699 26699
Misses 11939 11939 |
metamaskbot
added
the
release-11.1.0
Issue or pull request that will be included in release 11.1.0
label
Aug 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.1.0
Issue or pull request that will be included in release 11.1.0
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Updates the hardcoded derivation paths used in snaps.