Bump SES to fix audit failure

[FrederikBolding]

Explanation

Bump SES to fix audit failure that prevents pending PRs from being merged.

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: [email protected]

[georgewrmarshall]

LGMT! You have to add a team label to pass the label CI test I'm not sure which, maybe team-extension-platform?

• pulled branch and compared yarn audit results

[legobeat]

Unit test failure:

  non-modifiable intrinsics
    ✔ intrinsic globalThis["Infinity"]
    ✔ intrinsic globalThis["NaN"]
    ✔ intrinsic globalThis["undefined"]
    ✔ intrinsic globalThis["isFinite"]
    ✔ intrinsic globalThis["isNaN"]
    ✔ intrinsic globalThis["parseFloat"]
    ✔ intrinsic globalThis["parseInt"]
    ✔ intrinsic globalThis["decodeURI"]
    ✔ intrinsic globalThis["decodeURIComponent"]
    ✔ intrinsic globalThis["encodeURI"]
    ✔ intrinsic globalThis["encodeURIComponent"]
    ✔ intrinsic globalThis["Array"]
    ✔ intrinsic globalThis["ArrayBuffer"]
    ✔ intrinsic globalThis["BigInt"]
    ✔ intrinsic globalThis["BigInt64Array"]
    ✔ intrinsic globalThis["BigUint64Array"]
    ✔ intrinsic globalThis["Boolean"]
    ✔ intrinsic globalThis["DataView"]
    ✔ intrinsic globalThis["EvalError"]
    ✔ intrinsic globalThis["Float32Array"]
    ✔ intrinsic globalThis["Float64Array"]
    ✔ intrinsic globalThis["Int8Array"]
    ✔ intrinsic globalThis["Int16Array"]
    ✔ intrinsic globalThis["Int32Array"]
    ✔ intrinsic globalThis["Map"]
    ✔ intrinsic globalThis["Number"]
    ✔ intrinsic globalThis["Object"]
    ✔ intrinsic globalThis["Promise"]
    ✔ intrinsic globalThis["Proxy"]
    ✔ intrinsic globalThis["RangeError"]
    ✔ intrinsic globalThis["ReferenceError"]
    ✔ intrinsic globalThis["Set"]
    ✔ intrinsic globalThis["String"]
    ✔ intrinsic globalThis["SyntaxError"]
    ✔ intrinsic globalThis["TypeError"]
    ✔ intrinsic globalThis["Uint8Array"]
    ✔ intrinsic globalThis["Uint8ClampedArray"]
    ✔ intrinsic globalThis["Uint16Array"]
    ✔ intrinsic globalThis["Uint32Array"]
    ✔ intrinsic globalThis["URIError"]
    ✔ intrinsic globalThis["WeakMap"]
    ✔ intrinsic globalThis["WeakSet"]
    ✔ intrinsic globalThis["JSON"]
    ✔ intrinsic globalThis["Reflect"]
    ✔ intrinsic globalThis["escape"]
    ✔ intrinsic globalThis["unescape"]
    ✔ intrinsic globalThis["lockdown"]
    ✔ intrinsic globalThis["harden"]
    ✔ intrinsic globalThis["Date"]
    ✔ intrinsic globalThis["Error"]
    ✔ intrinsic globalThis["RegExp"]
    1) intrinsic globalThis["Symbol"]
    ✔ intrinsic globalThis["Math"]
    ✔ intrinsic globalThis["globalThis"]
    ✔ intrinsic globalThis["eval"]
    ✔ intrinsic globalThis["Function"]


 56 passing (14ms)
 1 failing

  1) non-modifiable intrinsics
       intrinsic globalThis["Symbol"]:

      AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: value of universal property globalThis["Symbol"] should be frozen
      + expected - actual

      -false
      +true
      
    at testIntrinsic (test/helpers/protect-intrinsics-helpers.js:39:20)
    at Context.<anonymous> (test/unit-global/protect-intrinsics.test.js:9:57)

[mcmire]

It looks like Symbol was tamed in 0.18.5: endojs/endo@9fb1242

If this change is relevant, what is the correct fix? Should we add Symbol to the ignorelist here? https://github.com/MetaMask/metamask-extension/blob/develop/test/helpers/protect-intrinsics-helpers.js#L16

[Gudahtt]

Alternatively we can freeze it by adding it to the shouldHardenManually array in lockdown-more.js

[mcmire]

Ah, yeah, that would make more sense.

[Gudahtt]

LGTM!

[codecov]

Codecov Report

Merging #20434 (30c1057) into develop (e02f597) will not change coverage.
Report is 21 commits behind head on develop.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20434   +/-   ##
========================================
  Coverage    68.84%   68.84%           
========================================
  Files          993      993           
  Lines        38258    38258           
  Branches     10248    10248           
========================================
  Hits         26338    26338           
  Misses       11920    11920           

[metamaskbot]

Builds ready [30c1057]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1567 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	113	199	139	25	12
		domContentLoaded	1432	1827	1567	113	54
		load	1432	1828	1567	113	54
		domInteractive	1432	1827	1567	113	54

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 10 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)