Force an update of the phishing warning configuration

[Gudahtt]

Explanation

The "last fetched" state for the PhishingController has been deleted to force an immediate full update of the phishing configuration state. We're doing this because the state was cleared in v10.34.2 because the format of that state had changed.

This has been implemented in migration 92. The previous migration 92 has been renamed to 93 because it won't be included until a future release. We need the migrations to remain sequential, and this will save us from having to resolve a complex conflict when releasing this.

Manual Testing Steps

• Install v10.34.1, onboard
• Navigate to this test website to ensure that it's blocked: https://test.metamask-phishing.io/
• update the directory you are loading the extension from to a v10.34.2 build
• See that the site is still blocked

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[danjm]

code looks good, will do a manual QA

[danjm]

manual QA passes. I could repro the bug on v10.34.2, but not on this branch.

I did the following:

1. Install v10.34.1, onboard
2. go to Add scams from ChainPatrol eth-phishing-detect#13184 and click the scam link
3. checkout this branch
4. edit metamask-controller.js so that a this.phishingController.setHotlistRefreshInterval(5); call is made (I edited the existing call to that function and moved it outside the if block)
5. yarn start
6. update the extension to this new build
7. In the background console, see a network request to https://phishing-detection.metafi.codefi.network/v1/diffsSince/-Infinity

[danjm]

LGTM

[metamaskbot]

Builds ready [654ff8d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1723 ± 97 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	110	193	154	24	12
		domContentLoaded	1420	2145	1723	203	97
		load	1420	2145	1723	203	97
		domInteractive	1420	2145	1723	203	97

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 890 Bytes (0.02%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)