Show a balance for the Token To, update position of the MM fee, removes a link #20030
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
E2E test failures seem related @dan437 |
Codecov Report
@@ Coverage Diff @@
## develop #20030 +/- ##
===========================================
- Coverage 69.47% 69.47% -0.00%
===========================================
Files 988 988
Lines 37313 37323 +10
Branches 9989 9996 +7
===========================================
+ Hits 25923 25929 +6
- Misses 11390 11394 +4
|
| `; |
There was a problem hiding this comment.
This change seems unintentional, and should likely be removed from the PR
There was a problem hiding this comment.
I've updated snapshots and this is what I got. When I run yarn jest --updateSnapshot now, it doesn't give me anything new.
| color: var(--color-primary-default); | ||
| } | ||
|
|
||
| &__quote-rate--no-link { | ||
| cursor: text; | ||
| color: var(--color-text-default); |
There was a problem hiding this comment.
Why use SCSS colors versus the color prop on Typography or Box?
| expect(getByText('Includes a 1% MetaMask fee –')).toBeInTheDocument(); | ||
| expect(getByText('view all quotes')).toBeInTheDocument(); |
There was a problem hiding this comment.
Does this constitute a change in our fee or just moving it around?
There was a problem hiding this comment.
No change in the fee logic, just making it clearer that our MM fee is included in quotes already.
|
@dan437 Looks like merging this start failing unit tests on Difference in behavior due to dc9801a not being rebased on |
Gudahtt
added
the
release-10.35.0
Explanation
Screenshots
Testing