Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated button label to "Add hardware wallet" in the Accounts Menu list #20026

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

NidhiKJha
Copy link
Member

This PR is to Update the label from Hardware wallet to Add hardware wallet

Screenshots/Screencaps

Before

Screenshot 2023-07-14 at 4 49 08 PM

After

Screenshot 2023-07-14 at 4 48 27 PM

Manual Testing Steps

  • Go to Account List Menu
  • Check the button label for hardware button

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@NidhiKJha NidhiKJha requested a review from a team as a code owner July 14, 2023 11:19
@NidhiKJha NidhiKJha added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #20026 (4123475) into develop (751120b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20026   +/-   ##
========================================
  Coverage    69.47%   69.47%           
========================================
  Files          988      988           
  Lines        37313    37313           
  Branches      9989     9989           
========================================
  Hits         25923    25923           
  Misses       11390    11390           
Impacted Files Coverage Δ
.../multichain/account-list-menu/account-list-menu.js 77.50% <ø> (ø)

@metamaskbot
Copy link
Collaborator

Builds ready [4123475]
Page Load Metrics (1680 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1112141522914
domContentLoaded14012318167320297
load140123181680210101
domInteractive14012318167320297
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 3 bytes
  • common: 7 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [4123475]
Page Load Metrics (1604 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1013791425627
domContentLoaded1480181116048239
load1480181316048239
domInteractive1480181116048239
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 3 bytes
  • common: 7 bytes

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Checked number of instances of hardwareWallet (only 1) ✅
  • Content follows content guidelines - sentence case ✅

@NidhiKJha NidhiKJha merged commit 7bdd76a into develop Jul 14, 2023
@NidhiKJha NidhiKJha deleted the fix-19999 branch July 14, 2023 15:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update button label to "Add hardware wallet" in the Accounts Menu list
4 participants