Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Use System Theme for tooltip #19954

Merged
merged 2 commits into from
Jul 11, 2023
Merged

UX: Use System Theme for tooltip #19954

merged 2 commits into from
Jul 11, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

When in dark mode, I see token list name tooltips in light theme mode. This makes the token name hard to read. This removes the casting that causes this problem.

Screenshots/Screencaps

SCR-20230710-ttgv

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 11, 2023 03:52
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing
Copy link
Contributor Author

Am I missing something here @NidhiKJha ?

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good 🚀

@metamaskbot
Copy link
Collaborator

Builds ready [bd178ad]
Page Load Metrics (1790 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1191941522612
domContentLoaded15942011178911053
load16162011179010952
domInteractive15932011178911053
Bundle size diffs
  • background: 0 bytes
  • ui: -87 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #19954 (bd178ad) into develop (1452803) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19954      +/-   ##
===========================================
- Coverage    69.52%   69.52%   -0.00%     
===========================================
  Files          983      983              
  Lines        37168    37166       -2     
  Branches      9965     9964       -1     
===========================================
- Hits         25841    25839       -2     
  Misses       11327    11327              
Impacted Files Coverage Δ
...ents/multichain/token-list-item/token-list-item.js 94.74% <ø> (-0.50%) ⬇️

@darkwing darkwing merged commit a8ad19d into develop Jul 11, 2023
@darkwing darkwing deleted the token-list-item-tooltip branch July 11, 2023 18:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants