-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Use System Theme for tooltip #19954
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Am I missing something here @NidhiKJha ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really good 🚀
Builds ready [bd178ad]
Page Load Metrics (1790 ± 52 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19954 +/- ##
===========================================
- Coverage 69.52% 69.52% -0.00%
===========================================
Files 983 983
Lines 37168 37166 -2
Branches 9965 9964 -1
===========================================
- Hits 25841 25839 -2
Misses 11327 11327
|
Explanation
When in dark mode, I see token list name tooltips in light theme mode. This makes the token name hard to read. This removes the casting that causes this problem.
Screenshots/Screencaps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.