Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19393 - Add indicator for Refresh list on tokens screen #19952

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

Clicking "Refresh list" in the token listing provide no feedback to the user that something is happening. This PR shows our current loading indicator to signal to the user that an action is taking place.

Manual Testing Steps

  1. Click "Refresh list"
  2. See indicator display momentarily
  3. See indicator disappear when complete

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 11, 2023 02:17
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [dc9a180]
Page Load Metrics (1939 ± 79 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1212181602512
domContentLoaded17072238193816579
load17072238193916579
domInteractive17072238193816579
Bundle size diffs
  • background: 0 bytes
  • ui: 108 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #19952 (dc9a180) into develop (13b1f8c) will decrease coverage by 0.01%.
The diff coverage is 22.22%.

@@             Coverage Diff             @@
##           develop   #19952      +/-   ##
===========================================
- Coverage    69.54%   69.53%   -0.01%     
===========================================
  Files          983      983              
  Lines        37161    37167       +6     
  Branches      9963     9963              
===========================================
+ Hits         25841    25842       +1     
- Misses       11320    11325       +5     
Impacted Files Coverage Δ
ui/store/actions.ts 42.07% <0.00%> (-0.13%) ⬇️
.../multichain/import-token-link/import-token-link.js 94.44% <100.00%> (+0.33%) ⬆️

@NidhiKJha NidhiKJha added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Jul 11, 2023
@darkwing darkwing merged commit 1452803 into develop Jul 11, 2023
@darkwing darkwing deleted the 19393-refresh-token-indicator branch July 11, 2023 15:43
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading indicator for "Refresh list" button on network selection screen
4 participants