Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Network Menu: Disable testnet toggle when on testnet #19951

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jul 11, 2023

Explanation

At present the "Disable / Enable" Test Networks toggle is always enabled. If a user is currently on a test network, however, it's best to leave that toggle on so that the user doesn't find themselves in a spot where the current network is hidden via the toggle

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/659

Screenshots/Screencaps

SCR-20230710-rwjv

Manual Testing Steps

  1. Open the Network Picker
  2. Choose the Goerli network, watch network switch
  3. Open the Network Picker again
  4. See that the toggle is disabled

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner July 11, 2023 01:36
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

NidhiKJha
NidhiKJha previously approved these changes Jul 11, 2023
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NidhiKJha NidhiKJha added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jul 11, 2023
DDDDDanica
DDDDDanica previously approved these changes Jul 11, 2023
@darkwing darkwing dismissed stale reviews from NidhiKJha and DDDDDanica via 091aef4 July 13, 2023 18:28
@darkwing darkwing force-pushed the disable-testnet-toggle branch from 3e4ec9c to 091aef4 Compare July 13, 2023 18:28
@metamaskbot
Copy link
Collaborator

Builds ready [091aef4]
Page Load Metrics (1548 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint105167125157
domContentLoaded1414167315486933
load1414167315486933
domInteractive1414167315486933
Bundle size diffs
  • background: 0 bytes
  • ui: 42 bytes
  • common: 0 bytes

@NidhiKJha NidhiKJha force-pushed the disable-testnet-toggle branch from 091aef4 to 34fc16b Compare July 14, 2023 10:57
@NidhiKJha
Copy link
Member

@darkwing I think this PR fixes this issue as well

Screen.Recording.2023-07-14.at.4.33.03.PM.mov

@NidhiKJha NidhiKJha requested a review from DDDDDanica July 14, 2023 11:05
@metamaskbot
Copy link
Collaborator

Builds ready [34fc16b]
Page Load Metrics (2098 ± 95 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1302511943416
domContentLoaded17392483209519594
load17392483209819795
domInteractive17392483209519594
Bundle size diffs
  • background: 0 bytes
  • ui: 3 bytes
  • common: 0 bytes

@darkwing darkwing merged commit 45b7b0c into develop Jul 14, 2023
@darkwing darkwing deleted the disable-testnet-toggle branch July 14, 2023 13:21
@github-actions github-actions bot locked and limited conversation to collaborators Jul 14, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants