Fix #19548 - Increase address copy to clipboard time

[darkwing]

Explanation

• Fixes [Bug]: Copying addresses to clipboard is not working #19548

Increases the time before clipboard gets cleared after copying a wallet address.

Manual Testing Steps

1. From the home screen, click the address button
2. Command-V several times to a new document until the clipboard eventually gets cleared

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [3603415]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1574 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	111	380	150	56	27
		domContentLoaded	1455	1784	1574	85	41
		load	1455	1784	1574	85	41
		domInteractive	1455	1784	1574	85	41

Bundle size diffs

• background: 0 bytes
• ui: 171 bytes
• common: 0 bytes

[metamaskbot]

Builds ready [f983445]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1636 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	105	298	143	40	19
		domContentLoaded	1486	1937	1636	112	54
		load	1487	1937	1636	112	54
		domInteractive	1486	1937	1636	112	54

Bundle size diffs

• background: 0 bytes
• ui: 168 bytes
• common: 0 bytes

[HowardBraham]

Is the default time really only 3 seconds? I expect there's a lot more places where this will be a problem.

Also, what happens if you copy from one place, wait 55 seconds, and then copy from another? Will the clipboard clear in 5 seconds?

[NidhiKJha]

I like this solution but if I copy address from account 1 then it stays copied and even I switch to account 2 the tooltip and icon is still in copied state even though the copied text is address from account 1. Functionality wise it's working fine and if I copy the address from account 2, it's updated.

Screen.Recording.2023-07-11.at.2.48.44.PM.mov

[metamaskbot]

Builds ready [dd9c379]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1565 ± 37 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	164	128	15	7
		domContentLoaded	1464	1793	1565	76	37
		load	1464	1793	1565	76	37
		domInteractive	1464	1793	1565	76	37

Bundle size diffs

• background: 0 bytes
• ui: 135 bytes
• common: 0 bytes

[codecov]

Codecov Report

Merging #19948 (dd9c379) into develop (13b1f8c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #19948   +/-   ##
========================================
  Coverage    69.54%   69.54%           
========================================
  Files          983      983           
  Lines        37161    37161           
  Branches      9963     9963           
========================================
  Hits         25841    25841           
  Misses       11320    11320           

Impacted Files	Coverage Δ
...tichain/address-copy-button/address-copy-button.js	100.00% <100.00%> (ø)

[plasmacorral]

On the IOS mobile client there is an expectation set for the user by including the following text "stored for 1 minute" when an SRP or private key is copied. Unfortunately, there was not an effective way to enforce the clipboard purge on Android.

Should we inform the user within the UI that the clipboard will be cleared after 1 minute?
Is the plan to purge all clipboard entries after 1 minute, or can we limit that purge just to Private Keys or SRP to be aligned with the mobile iOS client?

[danjm]

LGTM

[kevinghim]

Resolves #19948

[danjm]

On the IOS mobile client there is an expectation set for the user by including the following text "stored for 1 minute" when an SRP or private key is copied. Unfortunately, there was not an effective way to enforce the clipboard purge on Android.

Should we inform the user within the UI that the clipboard will be cleared after 1 minute?
Is the plan to purge all clipboard entries after 1 minute, or can we limit that purge just to Private Keys or SRP to be aligned with the mobile iOS client?

Extension product and design are going to look into these as future improvements, but we are going to just change the delay in this PR as an MVP, so we can get it into the v10.34.0 release.