Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misaligned icons in 'Connected sites' modal #19944

Merged
merged 4 commits into from
Jul 12, 2023
Merged

Fix misaligned icons in 'Connected sites' modal #19944

merged 4 commits into from
Jul 12, 2023

Conversation

jase-b
Copy link
Contributor

@jase-b jase-b commented Jul 10, 2023

Fixes #19901: Connected sites modal misaligned icons

Replaced <SiteIcon> with <AvatarFavicon> in <ConnectedSitesList>

Before

19901 before

After

border-muted

Manual Testing Steps

  • Log in to MetaMask.
  • Connect the wallet to at least one site (if not already).
  • Open the 'Connected sites' modal.
  • Observe all listed site icons are centered within their circular container element.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jase-b
Copy link
Contributor Author

jase-b commented Jul 10, 2023

I have read the CLA Document and I hereby sign the CLA

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #19944 (20a9a62) into develop (c206200) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19944      +/-   ##
===========================================
- Coverage    69.47%   69.46%   -0.01%     
===========================================
  Files          987      987              
  Lines        37270    37270              
  Branches      9979     9979              
===========================================
- Hits         25890    25888       -2     
- Misses       11380    11382       +2     
Impacted Files Coverage Δ
...ected-sites-list/connected-sites-list.component.js 46.15% <ø> (ø)

... and 2 files with indirect coverage changes

builds.yml Outdated Show resolved Hide resolved
@jase-b jase-b marked this pull request as ready for review July 11, 2023 22:57
@jase-b jase-b requested a review from a team as a code owner July 11, 2023 22:57
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look really great. I have suggested some changes to use border color and size from design-system constants. Thanks for your contribution @jase-b

@NidhiKJha NidhiKJha added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Jul 12, 2023
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution

@jase-b
Copy link
Contributor Author

jase-b commented Jul 12, 2023

LGTM! Thanks for your contribution

Happy to help and more to come 🤝

@NidhiKJha NidhiKJha merged commit c778256 into MetaMask:develop Jul 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2023
@vthomas13
Copy link
Contributor

Congrats @jase-b! Really appreciate the contribution 😁

@jase-b jase-b deleted the fix/19901-connected-sites-modal-misaligned-icons branch July 13, 2023 05:17
@Gudahtt Gudahtt added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connected sites modal misaligned icons
4 participants