-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix misaligned icons in 'Connected sites' modal #19944
Fix misaligned icons in 'Connected sites' modal #19944
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
Codecov Report
@@ Coverage Diff @@
## develop #19944 +/- ##
===========================================
- Coverage 69.47% 69.46% -0.01%
===========================================
Files 987 987
Lines 37270 37270
Branches 9979 9979
===========================================
- Hits 25890 25888 -2
- Misses 11380 11382 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look really great. I have suggested some changes to use border color and size from design-system constants. Thanks for your contribution @jase-b
ui/components/app/connected-sites-list/connected-sites-list.component.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Nidhi Kumari <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution
Happy to help and more to come 🤝 |
Congrats @jase-b! Really appreciate the contribution 😁 |
Fixes #19901: Connected sites modal misaligned icons
Replaced
<SiteIcon>
with<AvatarFavicon>
in<ConnectedSitesList>
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist