Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Fix Snaps UI divider #19919

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

FrederikBolding
Copy link
Member

Explanation

Fixes the Snaps UI divider by recreating it using a Box. It now has the same color as the snaps delineator, which was always intended.

@FrederikBolding FrederikBolding requested review from a team as code owners July 7, 2023 12:44
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #19919 (c6776aa) into develop (484dae3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #19919   +/-   ##
========================================
  Coverage    69.54%   69.54%           
========================================
  Files          983      983           
  Lines        37162    37162           
  Branches      9965     9965           
========================================
  Hits         25843    25843           
  Misses       11319    11319           
Impacted Files Coverage Δ
.../metamask-template-renderer/safe-component-list.js 100.00% <ø> (ø)

@FrederikBolding FrederikBolding merged commit 4918aa4 into develop Jul 7, 2023
@FrederikBolding FrederikBolding deleted the fb/fix-snaps-ui-divider branch July 7, 2023 13:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 7, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [c6776aa]
Page Load Metrics (1580 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint98166122157
domContentLoaded14351848158010852
load14351848158010852
domInteractive14351848158010852
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flask release-10.35.0 Issue or pull request that will be included in release 10.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants