Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fetch for snap registry #19866

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

montelaidev
Copy link
Contributor

Explanation

Fixes the fetch call to the keyring snaps registry

Pre-merge author checklist

  • [x ] I've clearly explained:
    • [ x] What problem this PR is solving
    • [ x] How this problem was solved
    • [ x] How reviewers can test my changes
  • Sufficient automated test coverage has been added

@montelaidev montelaidev requested a review from a team as a code owner July 4, 2023 10:13
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #19866 (b054c28) into develop (18699cc) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #19866      +/-   ##
===========================================
- Coverage    69.68%   69.68%   -0.00%     
===========================================
  Files          982      982              
  Lines        37067    37068       +1     
  Branches      9941     9941              
===========================================
  Hits         25829    25829              
- Misses       11238    11239       +1     
Impacted Files Coverage Δ
app/scripts/controllers/preferences.js 71.43% <100.00%> (-0.41%) ⬇️

@metamaskbot
Copy link
Collaborator

Builds ready [b054c28]
Page Load Metrics (1768 ± 143 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint113174137189
domContentLoaded151225251768298143
load151225251768298143
domInteractive151225251768298143
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Copy link
Contributor

@legobeat legobeat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@montelaidev montelaidev merged commit daf3732 into develop Jul 5, 2023
@montelaidev montelaidev deleted the fix/keyring-snap-registry-fetch branch July 5, 2023 12:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 5, 2023
@danjm danjm added release-blocker This bug is blocking the next release release-10.34.0 Issue or pull request that will be included in release 10.34.0 and removed release-10.35.0 Issue or pull request that will be included in release 10.35.0 labels Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.34.0 Issue or pull request that will be included in release 10.34.0 release-blocker This bug is blocking the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants