-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fetch for snap registry #19866
Merged
Merged
fix: fetch for snap registry #19866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19866 +/- ##
===========================================
- Coverage 69.68% 69.68% -0.00%
===========================================
Files 982 982
Lines 37067 37068 +1
Branches 9941 9941
===========================================
Hits 25829 25829
- Misses 11238 11239 +1
|
Builds ready [b054c28]
Page Load Metrics (1768 ± 143 ms)
Bundle size diffs
|
legobeat
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
gantunesr
approved these changes
Jul 5, 2023
metamaskbot
added
the
release-10.35.0
Issue or pull request that will be included in release 10.35.0
label
Jul 5, 2023
danjm
added
release-blocker
This bug is blocking the next release
release-10.34.0
Issue or pull request that will be included in release 10.34.0
and removed
release-10.35.0
Issue or pull request that will be included in release 10.35.0
labels
Jul 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-10.34.0
Issue or pull request that will be included in release 10.34.0
release-blocker
This bug is blocking the next release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes the fetch call to the keyring snaps registry
Pre-merge author checklist