Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19832 - UX: Multichain: Move location of test networks #19812

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Jun 28, 2023

Explanation

It was pointed out by @SaraCheikh that the test networks need to display under the toggle, not with the rest of the networks

ToDo

  • Add a dozen accounts and ensure the modal still looks good in popup (doesn't require the user to scroll through the entire popup).

Screenshots/Screencaps

SCR-20230628-oarf

Manual Testing Steps

  1. Open the network menu
  2. Toggle on and off the "Show Test Networks" toggle

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner June 28, 2023 20:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [25bc7bd]
Page Load Metrics (1622 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint102190133199
domContentLoaded1454174716228139
load1454174716228139
domInteractive1454174716228139
Bundle size diffs
  • background: 0 bytes
  • ui: -213 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #19812 (a678617) into develop (230c0c6) will increase coverage by 0.00%.
The diff coverage is 80.56%.

@@           Coverage Diff            @@
##           develop   #19812   +/-   ##
========================================
  Coverage    69.84%   69.84%           
========================================
  Files          981      981           
  Lines        36941    36939    -2     
  Branches      9913     9911    -2     
========================================
- Hits         25799    25798    -1     
+ Misses       11142    11141    -1     
Impacted Files Coverage Δ
.../multichain/network-list-menu/network-list-menu.js 69.09% <73.08%> (-0.91%) ⬇️
ui/selectors/selectors.js 86.81% <100.00%> (+0.07%) ⬆️

@metamaskbot
Copy link
Collaborator

Builds ready [a678617]
Page Load Metrics (1794 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1061921552713
domContentLoaded15852120179413665
load15852120179413666
domInteractive15852120179413665
Bundle size diffs
  • background: 0 bytes
  • ui: 80 bytes
  • common: 0 bytes

@darkwing darkwing changed the title UX: Multichain: Move location of test networks Fix #19832 - UX: Multichain: Move location of test networks Jun 29, 2023
@NidhiKJha NidhiKJha added DO-NOT-MERGE Pull requests that should not be merged and removed DO-NOT-MERGE Pull requests that should not be merged labels Jul 4, 2023
@NidhiKJha NidhiKJha merged commit fdac94e into develop Jul 5, 2023
@NidhiKJha NidhiKJha deleted the network-menu-test-placement branch July 5, 2023 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 5, 2023
@NidhiKJha NidhiKJha added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: UX: Multichain Network Menu: Move location of test networks
4 participants