Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render correct image in the asset dropdown while sending an NFT #19787

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

NidhiKJha
Copy link
Member

In the asset dropdown, the native token image was changed to the selected NFT image while sending an NFT. This PR is to fix this and to ensure the correct image is displayed in the asset dropdown while sending an NFT.

Screenshots/Screencaps

Before

Screen.Recording.2023-06-27.at.8.47.31.PM.mov

After

Screen.Recording.2023-06-27.at.8.44.39.PM.mov

Manual Testing Steps

  • Select an asset and click on send
  • In the asset dropdown, select nft
  • Check the native token has its own logo and not the nft image in asset dropdown.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@NidhiKJha NidhiKJha requested a review from a team as a code owner June 27, 2023 15:19
@NidhiKJha NidhiKJha added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #19787 (a8318b8) into develop (bf8f606) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #19787   +/-   ##
========================================
  Coverage    69.83%   69.83%           
========================================
  Files          981      981           
  Lines        36939    36936    -3     
  Branches      9913     9910    -3     
========================================
- Hits         25796    25794    -2     
+ Misses       11143    11142    -1     
Impacted Files Coverage Δ
...content/send-asset-row/send-asset-row.component.js 68.67% <100.00%> (+0.07%) ⬆️

@metamaskbot
Copy link
Collaborator

Builds ready [a8318b8]
Page Load Metrics (1623 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1081991412613
domContentLoaded14562056162215574
load14562056162315574
domInteractive14562056162215574
Bundle size diffs
  • background: 0 bytes
  • ui: -174 bytes
  • common: 0 bytes

@NidhiKJha NidhiKJha merged commit fa84aa8 into develop Jul 4, 2023
@NidhiKJha NidhiKJha deleted the fix-19783 branch July 4, 2023 13:00
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Sending the native protocol token displays NFT icon if previously selected that NFT
5 participants