Fixing scroll references for Advanced and Security settings

[ryanml]

Related: #19479

Explanation

When anchoring to a settings search result that exists on the Advanced and Security tabs, many of the settings weren't scrolled to correctly, or at all. This is because there was an off by one error in the references ordering in the tab components when compared to the route positions in the settings constants. This PR fixes those off by ones, and in addition for Security constants, standardizes and fixes misspellings in the hash routes.

Before

(See video in referenced issue)

After

settings-fix.mov

Manual Testing Steps

1. Navigate to the General Settings tab
2. Using the settings search input, search for and anchor to various advanced and security settings. (Show balance and token price checker, Show hex data, Choose your network, etc)
3. Ensure each setting clicked from in the suggestions is correctly scrolled to.

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

cc: @NiranjanaBinoy

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Merging #19771 (f271017) into develop (04839a2) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19771      +/-   ##
===========================================
- Coverage    69.85%   69.85%   -0.01%     
===========================================
  Files          980      980              
  Lines        36909    36909              
  Branches      9908     9908              
===========================================
- Hits         25782    25780       -2     
- Misses       11127    11129       +2     

Impacted Files	Coverage Δ
ui/helpers/constants/settings.js	33.78% <ø> (ø)
...es/settings/advanced-tab/advanced-tab.component.js	59.76% <ø> (ø)
...es/settings/security-tab/security-tab.component.js	77.42% <ø> (ø)

... and 2 files with indirect coverage changes

[NiranjanaBinoy]

The changes look good to me.

Good to see you @ryanml

[NidhiKJha]

LGTM! Thanks, @ryanml