Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #19764 - Move Token Options Menu #19765

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

darkwing
Copy link
Contributor

Explanation

  1. Make the token's three-dot menu smaller
  2. Move it next to the breadcrumbs
  3. Remove the "Account Details" option from the token detail menu

Screenshots/Screencaps

SCR-20230626-nkir

Manual Testing Steps

  1. Click into any token -- see the three-dot menu
  2. Click the menu to see it working

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner June 26, 2023 20:14
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks great to me. Just a question, since the list item only has one item for the token, should we change the menu item to a button? cc @SaraCheikh

Screen.Recording.2023-06-27.at.11.51.06.AM.mov

@SaraCheikh
Copy link

@NidhiKJha, we considered that option but we decided to keep the menu icon because in the non native tokens we would need to display more menu items: hide token and token details.

@darkwing darkwing force-pushed the 19764-token-options branch from 6108c35 to ef45b01 Compare June 27, 2023 20:35
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #19765 (ef45b01) into develop (b36487a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19765      +/-   ##
===========================================
+ Coverage    69.83%   69.85%   +0.02%     
===========================================
  Files          981      981              
  Lines        36939    36930       -9     
  Branches      9913     9913              
===========================================
  Hits         25795    25795              
+ Misses       11144    11135       -9     
Impacted Files Coverage Δ
ui/components/multichain/app-header/app-header.js 50.44% <ø> (ø)
ui/pages/asset/components/asset-navigation.js 100.00% <ø> (ø)
ui/pages/asset/components/asset-options.js 6.67% <ø> (+0.42%) ⬆️
ui/pages/asset/components/native-asset.js 6.25% <ø> (+0.99%) ⬆️
ui/pages/asset/components/token-asset.js 5.00% <ø> (+0.45%) ⬆️

... and 1 file with indirect coverage changes

@metamaskbot
Copy link
Collaborator

Builds ready [ef45b01]
Page Load Metrics (1511 ± 27 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint105178121168
domContentLoaded1431164515105527
load1431164515115527
domInteractive1431164515105527
Bundle size diffs
  • background: 0 bytes
  • ui: -544 bytes
  • common: 0 bytes

@NidhiKJha NidhiKJha merged commit aa95fe8 into develop Jul 4, 2023
@NidhiKJha NidhiKJha deleted the 19764-token-options branch July 4, 2023 12:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 4, 2023
@NidhiKJha NidhiKJha added the team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead label Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UX: Multichain: Update the design of the token's three-dot menu
5 participants