-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #19764 - Move Token Options Menu #19765
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation looks great to me. Just a question, since the list item only has one item for the token, should we change the menu item to a button? cc @SaraCheikh
Screen.Recording.2023-06-27.at.11.51.06.AM.mov
@NidhiKJha, we considered that option but we decided to keep the menu icon because in the non native tokens we would need to display more menu items: hide token and token details. |
6108c35
to
ef45b01
Compare
Codecov Report
@@ Coverage Diff @@
## develop #19765 +/- ##
===========================================
+ Coverage 69.83% 69.85% +0.02%
===========================================
Files 981 981
Lines 36939 36930 -9
Branches 9913 9913
===========================================
Hits 25795 25795
+ Misses 11144 11135 -9
|
Builds ready [ef45b01]
Page Load Metrics (1511 ± 27 ms)
Bundle size diffs
|
Explanation
In this PR, I:
Screenshots/Screencaps
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.