-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multichain Activity Screen #19557
Merged
Merged
Multichain Activity Screen #19557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [29fce84]
Page Load Metrics (1605 ± 37 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19557 +/- ##
===========================================
- Coverage 69.46% 69.41% -0.05%
===========================================
Files 989 990 +1
Lines 37361 37399 +38
Branches 10018 10032 +14
===========================================
+ Hits 25952 25960 +8
- Misses 11409 11439 +30
|
vthomas13
force-pushed
the
mc-activity-screen
branch
from
June 13, 2023 21:50
29fce84
to
acd9931
Compare
darkwing
reviewed
Jun 14, 2023
ui/components/multichain/activity-list-item/activity-list-item.js
Outdated
Show resolved
Hide resolved
vthomas13
force-pushed
the
mc-activity-screen
branch
5 times, most recently
from
June 20, 2023 15:32
8e3be55
to
1cc1076
Compare
vthomas13
force-pushed
the
mc-activity-screen
branch
2 times, most recently
from
June 20, 2023 22:08
176d449
to
8bec707
Compare
darkwing
force-pushed
the
mc-activity-screen
branch
3 times, most recently
from
June 23, 2023 20:56
5a55585
to
a53c7c8
Compare
vthomas13
force-pushed
the
mc-activity-screen
branch
from
June 26, 2023 20:03
50133af
to
a21fa5d
Compare
NidhiKJha
previously requested changes
Jun 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vthomas13
force-pushed
the
mc-activity-screen
branch
2 times, most recently
from
June 28, 2023 14:48
65eb2cf
to
e1c4123
Compare
vthomas13
force-pushed
the
mc-activity-screen
branch
from
July 6, 2023 13:59
7d0db5b
to
83b9a22
Compare
vthomas13
force-pushed
the
mc-activity-screen
branch
from
July 10, 2023 13:53
a1b1c97
to
d31cd5d
Compare
vthomas13
force-pushed
the
mc-activity-screen
branch
from
July 17, 2023 15:04
93807ca
to
fa3e83d
Compare
Builds ready [fa3e83d]
Page Load Metrics (1577 ± 63 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
darkwing
approved these changes
Jul 17, 2023
NidhiKJha
approved these changes
Jul 17, 2023
metamaskbot
added
the
release-10.35.0
Issue or pull request that will be included in release 10.35.0
label
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.