Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multichain Activity Screen #19557

Merged
merged 35 commits into from
Jul 17, 2023
Merged

Multichain Activity Screen #19557

merged 35 commits into from
Jul 17, 2023

Conversation

vthomas13
Copy link
Contributor

@vthomas13 vthomas13 commented Jun 9, 2023

Explanation

  • Deleted dividers between cells
  • Added network badge on action icons
  • Grouped txs by date
  • Minor UX improvements, see Figma

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [29fce84]
Page Load Metrics (1605 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint983101324321
domContentLoaded1445174315778742
load1455174316057837
domInteractive1445174315778742
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #19557 (fa3e83d) into develop (0309858) will decrease coverage by 0.05%.
The diff coverage is 51.56%.

@@             Coverage Diff             @@
##           develop   #19557      +/-   ##
===========================================
- Coverage    69.46%   69.41%   -0.05%     
===========================================
  Files          989      990       +1     
  Lines        37361    37399      +38     
  Branches     10018    10032      +14     
===========================================
+ Hits         25952    25960       +8     
- Misses       11409    11439      +30     
Impacted Files Coverage Δ
...list-item/smart-transaction-list-item.component.js 3.12% <0.00%> (ø)
...app/transaction-list/transaction-list.component.js 41.10% <25.00%> (-7.05%) ⬇️
...omponents/app/transaction-icon/transaction-icon.js 84.62% <80.00%> (-1.10%) ⬇️
...ultichain/activity-list-item/activity-list-item.js 85.00% <85.00%> (ø)
...ction-list-item/transaction-list-item.component.js 70.00% <100.00%> (+0.91%) ⬆️

... and 5 files with indirect coverage changes

@vthomas13 vthomas13 force-pushed the mc-activity-screen branch from 29fce84 to acd9931 Compare June 13, 2023 21:50
@vthomas13 vthomas13 force-pushed the mc-activity-screen branch 5 times, most recently from 8e3be55 to 1cc1076 Compare June 20, 2023 15:32
@vthomas13 vthomas13 marked this pull request as ready for review June 20, 2023 16:02
@vthomas13 vthomas13 requested a review from a team as a code owner June 20, 2023 16:02
@vthomas13 vthomas13 requested a review from NiranjanaBinoy June 20, 2023 16:02
@vthomas13 vthomas13 changed the title WIP: Multichain Activity Screen Multichain Activity Screen Jun 20, 2023
@vthomas13 vthomas13 requested a review from NidhiKJha June 20, 2023 18:00
@vthomas13 vthomas13 force-pushed the mc-activity-screen branch 2 times, most recently from 176d449 to 8bec707 Compare June 20, 2023 22:08
@vthomas13 vthomas13 marked this pull request as draft June 20, 2023 23:00
@darkwing darkwing marked this pull request as ready for review June 22, 2023 17:12
@darkwing darkwing force-pushed the mc-activity-screen branch 3 times, most recently from 5a55585 to a53c7c8 Compare June 23, 2023 20:56
@vthomas13 vthomas13 force-pushed the mc-activity-screen branch from 50133af to a21fa5d Compare June 26, 2023 20:03
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really great 🚀 . Just need to fix the storybook errors and also the image for the badge is not loading in storybook
Screenshot 2023-06-27 at 8 01 25 PM

@vthomas13 vthomas13 force-pushed the mc-activity-screen branch from 93807ca to fa3e83d Compare July 17, 2023 15:04
@metamaskbot
Copy link
Collaborator

Builds ready [fa3e83d]
Page Load Metrics (1577 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint971991352713
domContentLoaded13451940157713163
load13451940157713163
domInteractive13451940157713163
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 bytes
  • ui: -7586 bytes
  • common: -24 bytes

@vthomas13 vthomas13 dismissed NidhiKJha’s stale review July 17, 2023 17:47

Will address in future issue

@vthomas13 vthomas13 merged commit 4dcde1e into develop Jul 17, 2023
@vthomas13 vthomas13 deleted the mc-activity-screen branch July 17, 2023 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Jul 17, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.35.0 Issue or pull request that will be included in release 10.35.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants