Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feature: Add legacy derivation path to Trezor" #19451

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

brad-decker
Copy link
Contributor

Reverts #19443

Was asked to do this by @plasmacorral who is in the process of testing the commit. Communication about this happened in slack and was not reflected on the PR which led to it being merged.

@brad-decker brad-decker requested a review from a team as a code owner June 5, 2023 17:48
@brad-decker brad-decker requested a review from mcmire June 5, 2023 17:48
@metamaskbot
Copy link
Collaborator

Builds ready [11f09e1]
Page Load Metrics (1468 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88158106178
domContentLoaded1341153814394421
load1342161014687033
domInteractive1341153814394421
Bundle size diffs
  • background: 0 bytes
  • ui: -50 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #19451 (11f09e1) into develop (36de02f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #19451   +/-   ##
========================================
  Coverage    69.94%   69.94%           
========================================
  Files          959      959           
  Lines        36822    36822           
  Branches      9455     9455           
========================================
  Hits         25753    25753           
  Misses       11069    11069           
Impacted Files Coverage Δ
ui/pages/create-account/connect-hardware/index.js 42.76% <ø> (ø)

@plasmacorral plasmacorral merged commit b5ef94b into develop Jun 5, 2023
@plasmacorral plasmacorral deleted the revert-19443-trezor-ledger-legacy branch June 5, 2023 18:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2023
@plasmacorral plasmacorral restored the revert-19443-trezor-ledger-legacy branch June 5, 2023 18:20
@plasmacorral plasmacorral deleted the revert-19443-trezor-ledger-legacy branch June 5, 2023 18:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants