-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 17670 replace typography with text #19433
Issue 17670 replace typography with text #19433
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ujwalkumar1995, this is looking great! I've made some small updates while I had your brach checked out on my local. Thanks for your contribution!
ui/components/app/signature-request/signature-request-message/signature-request-message.js
Outdated
Show resolved
Hide resolved
ui/components/app/signature-request/signature-request-message/signature-request-message.js
Outdated
Show resolved
Hide resolved
ui/components/app/signature-request/signature-request.component.js
Outdated
Show resolved
Hide resolved
ui/components/app/signature-request-original/signature-request-original.component.js
Show resolved
Hide resolved
abf4bc7
to
f5c9cd7
Compare
Thank you @georgewrmarshall for the feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
94461f9
94461f9
to
e98dcd4
Compare
Codecov Report
@@ Coverage Diff @@
## develop #19433 +/- ##
===========================================
- Coverage 69.83% 69.82% -0.01%
===========================================
Files 980 980
Lines 36886 36886
Branches 9890 9890
===========================================
- Hits 25757 25755 -2
- Misses 11129 11131 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Explanation
As part of this PR, I have replaced the usage of Typography with Text. The files are:
Screenshots/Screencaps
Before
ui/components/ui/numeric-input/numeric-input.component.js:
Default:
With Detail:
With Error:
ui/components/app/signature-request/signature-request-message/signature-request-message.js:
ui/components/app/signature-request/signature-request.component.js:
After
ui/components/ui/numeric-input/numeric-input.component.js:
Default:
With Detail:
With Error:
ui/components/app/signature-request/signature-request-message/signature-request-message.js:
ui/components/app/signature-request/signature-request.component.js:
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.