Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Allow Snaps to use eth_accounts as a revokable permission #19306

Merged
merged 14 commits into from
Jul 6, 2023

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented May 26, 2023

Explanation

Allows Snaps to access eth_accounts as a revokable permission. This means that snaps now can use eth_accounts and eth_requestAccounts to prompt the user for account selection. This permission can be revoked again in the snaps settings whenever.

This PR is mainly UI changes to make the account connection flow work with these changes and UI additions for permission revoking.

This PR needs the latest, unpublished version of the snaps monorepo to work completely.

@FrederikBolding FrederikBolding added flask team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead labels May 26, 2023
@FrederikBolding FrederikBolding marked this pull request as ready for review July 5, 2023 12:13
@FrederikBolding FrederikBolding requested review from a team as code owners July 5, 2023 12:13
@metamaskbot
Copy link
Collaborator

Builds ready [08c38ec]
Page Load Metrics (1518 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1092121302110
domContentLoaded1408165515185728
load1408165515185728
domInteractive1408165515185728
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: -44876 bytes
  • ui: 607 bytes
  • common: 44973 bytes

@FrederikBolding FrederikBolding merged commit f829f00 into develop Jul 6, 2023
@FrederikBolding FrederikBolding deleted the fb/snap-eth-accounts branch July 6, 2023 20:54
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2023
@metamaskbot metamaskbot added the release-10.35.0 Issue or pull request that will be included in release 10.35.0 label Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flask release-10.35.0 Issue or pull request that will be included in release 10.35.0 team-snaps DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants