-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASK] Allow Snaps to use eth_accounts
as a revokable permission
#19306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrederikBolding
added
flask
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
labels
May 26, 2023
FrederikBolding
force-pushed
the
fb/snap-eth-accounts
branch
from
June 21, 2023 11:28
982b257
to
be2d4c6
Compare
FrederikBolding
force-pushed
the
fb/snap-eth-accounts
branch
from
July 5, 2023 07:41
c286ae0
to
3555cab
Compare
hmalik88
reviewed
Jul 5, 2023
GuillaumeRx
reviewed
Jul 6, 2023
GuillaumeRx
approved these changes
Jul 6, 2023
hmalik88
approved these changes
Jul 6, 2023
Builds ready [08c38ec]
Page Load Metrics (1518 ± 28 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
metamaskbot
added
the
release-10.35.0
Issue or pull request that will be included in release 10.35.0
label
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
flask
release-10.35.0
Issue or pull request that will be included in release 10.35.0
team-snaps
DEPRECATED: Use "team-snaps-platform" or "team-snaps-ecosystem" instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Allows Snaps to access
eth_accounts
as a revokable permission. This means that snaps now can useeth_accounts
andeth_requestAccounts
to prompt the user for account selection. This permission can be revoked again in the snaps settings whenever.This PR is mainly UI changes to make the account connection flow work with these changes and UI additions for permission revoking.
This PR needs the latest, unpublished version of the snaps monorepo to work completely.