Support hex and number net_version responses
#19156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Note that the lint failure appears to be on Edit: Fixed in this PR: #19157 |
mcmire
approved these changes
May 15, 2023
| ], | ||
| stubLookupNetworkWhileSetting: true, | ||
| }); | ||
| const validNetworkIds = [12345, '12345', toHex(12345)]; |
There was a problem hiding this comment.
Nit: Is it worth adding a test for an invalid network ID? Could do this in a new PR as well.
There was a problem hiding this comment.
Good thought, but we already covered this below (using the id invalid).
Hex and number responses from the `net_version` request are now accepted. While most chains return decimal strings for this request, some chains were returning hex responses instead and failing our validation for this request (which was added in v10.30.0). This resolves that problem. Support for number responses was added because it likely worked in older versions as well, so support is maintained to avoid similar problems. Fixes #19151
Gudahtt
force-pushed
the
support-hex-response-to-net_version
branch
from
5616f6b to
fa4f45f
Compare
|
Thank you folks from SKALE! |
Builds ready [fa4f45f]
Page Load Metrics (1672 ± 33 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Hex and number responses from the
net_versionrequest are now accepted. While most chains return decimal strings for this request, some chains were returning hex responses instead and failing our validation for this request (which was added in v10.30.0). This resolves that problem.Support for number responses was added because it likely worked in older versions as well, so support is maintained to avoid similar problems.
Fixes #19151
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.