Overriding gas estimate in the send page even if enough ETH is not available

[NiranjanaBinoy]

Explanation

Fixes #17966
Removing the gas warning and enabling the next button on the send page even when enough ETH is not available for gas.

Manual Testing Steps

1. Start a send transaction
2. Enter the maximum amount
3. Make sure the gas warning message is not displayed and Next button is active

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [92b30fc]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1552 ± 35 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	135	106	10	5
		domContentLoaded	1417	1667	1533	69	33
		load	1444	1719	1552	74	35
		domInteractive	1417	1666	1533	69	33

Bundle size diffs

• background: 0 bytes
• ui: 44 bytes
• common: 0 bytes

[digiwand]

I think it would be good to add a test for the new logic. Can we add a follow-up PR for this or handle it in this PR?

[NiranjanaBinoy]

@seaona Can we do a round of QA review on this PR to make sure these changes have not affected the other existing scenarios?

[seaona]

The behavior seems to work as expected @NiranjanaBinoy 👍 and flows seem to work normally.

• We are not blocking the button to proceed to the Confirmation screen and the warning info does not appear on the Edit screen.
• The Confirmation screen works as before, blocking the Confirm button if there are not enough funds with the appropriate warnings.

So from QA looks good.

---

I've reviewed the current Warnings/input validations on Edit and Confirm screens and it seems that they are not super consolidated across different network types. See:

On EIP1559 networks (i.e. Mainnet)

• When I am on the Edit screen with an EIP1559 network (i.e. Mainnet), if I set an Amount bigger than my balance I see this input validation error Insufficient funds for gas

• And if I proceed I see this warning You do not have enough ETH in your account to pay for transaction fees on Ethereum Mainnet network. Buy ETH or deposit from another account.

• On ERC20 Approve screen, we see Insufficient funds for gas warning

• On ERC721 Approve/SetApprovalForAll, we see You do not have enough ETH in your account to pay for transaction fees on Ethereum Mainnet network. Buy ETH or deposit from another account.

On non EIP1559 networks (i.e. Polygon zkEVM)

When I am on Edit screen, I see the following input validation errors:

And if I proceed I see this warning Insufficient funds..

@bschorchit do we need to consolidate them somehow? This should be a separate issue in case we want to change it.