-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated onClick of close button to call the same autohide fxn as the … #18504
Merged
seaona
merged 6 commits into
MetaMask:develop
from
dswilson4:NFT-added-close-toast-notification
Apr 17, 2023
Merged
updated onClick of close button to call the same autohide fxn as the … #18504
seaona
merged 6 commits into
MetaMask:develop
from
dswilson4:NFT-added-close-toast-notification
Apr 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…NFT import removal
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Pistondo
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
zone-live
approved these changes
Apr 14, 2023
digiwand
approved these changes
Apr 14, 2023
I've re-run the failing pipeline. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…NFT import removal
Explanation
Referenced issue:
#18485
Problem: after adding an NFT, I cannot close the Toast Notification by clicking on the cross sign.
There's an
onAutoHide
fxn that is used in the removeNftMessage<ButtonIcon/>
component to close the toast notification that wasn't being called in the newNftAddedMessage component. Calling this in an onClick allows the toast notification to close without relying on the autohide duration.Screenshots/Screencaps
Before
After
Manual Testing Steps
yarn start
x
to close the toast notification, should work on this branch but notdevelop
. The remove nft toast notification should work on both branchesPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.