Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hold to reveal button #18496

Merged
merged 1 commit into from
Apr 10, 2023
Merged

Conversation

georgewrmarshall
Copy link
Contributor

@georgewrmarshall georgewrmarshall commented Apr 6, 2023

Explanation

Currently the hold to reveal SRP button alignment is broken

Screenshots/Screencaps

Before

Screenshot 2023-04-06 at 3 30 20 PM

before.mov

After

Screenshot 2023-04-06 at 3 36 30 PM

after.mov

Manual Testing Steps

  • Go to the storybook build of this PR
  • Search HoldToRevealButton
  • See fixed alignment

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@georgewrmarshall georgewrmarshall self-assigned this Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall added type-bug team-design-system All issues relating to design system in Extension labels Apr 6, 2023
@georgewrmarshall georgewrmarshall marked this pull request as ready for review April 6, 2023 22:52
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner April 6, 2023 22:52
@georgewrmarshall georgewrmarshall requested a review from jpuri April 6, 2023 22:53
@metamaskbot
Copy link
Collaborator

Builds ready [6982958]
Page Load Metrics (1684 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint932281262713
domContentLoaded14821926165011957
load15152032168412560
domInteractive14821926165011957
Bundle size diffs
  • background: 0 bytes
  • ui: 80 bytes
  • common: 0 bytes

@NidhiKJha NidhiKJha merged commit f31596a into develop Apr 10, 2023
@NidhiKJha NidhiKJha deleted the fix/18495/hold-to-reveal-button branch April 10, 2023 05:57
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
@PeterYinusa PeterYinusa added the release-10.29.0 Issue or pull request that will be included in release 10.29.0 label Apr 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rc-cherry-picked release-10.29.0 Issue or pull request that will be included in release 10.29.0 team-design-system All issues relating to design system in Extension type-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hold to reveal button broken
6 participants