-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specific origin to direct to second page of token allowance flow #18395
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
My concerns are resolved but I shouldn't be the one to approve.
Builds ready [0511fcd]
Page Load Metrics (1595 ± 62 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18395 +/- ##
========================================
Coverage 64.69% 64.69%
========================================
Files 925 925
Lines 35584 35590 +6
Branches 9136 9138 +2
========================================
+ Hits 23018 23023 +5
- Misses 12566 12567 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@danjm : the change looks good to me. I will create a followup ticket for confirmations team to add unit test cases for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But it we should add an e2e test case for this as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked for ways to spoof that hostname but none still work, so this seems reasonable.
Explanation
Bridging functionality on the portfolio dapp is non-optimal because users are unknowingly customizing their token allowances to error prone amounts. This PR mitigates the problem by taking those users directly to second screen of the token allowance flow, thereby lowering the chance that they inadvertently customize the pDapps suggested allowance amount.
Screenshots/Screencaps
Peek.2023-03-31.00-35.mp4
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.