NFTs: Use Unknown Collection instead of first NFT name #18388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
8 tasks
danjm
requested changes
Mar 30, 2023
danjm
reviewed
Mar 30, 2023
| @@ -34,7 +34,7 @@ export default function NftsTab({ onAddNFT }) { | |||
| const dispatch = useDispatch(); | |||
|
|
|||
| const { nftsLoading, collections, previouslyOwnedCollection } = | |||
| useNftsCollections(); | |||
| useNftsCollections(t('nftsPreviouslyOwned'), t('unknownCollection')); | |||
There was a problem hiding this comment.
I don't think we have a translation for 'nftsPreviouslyOwned'
There was a problem hiding this comment.
Fixed, that should've been in initial commit.
Builds ready [405fc8f]
Page Load Metrics (1713 ± 47 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18388 +/- ##
========================================
Coverage 64.66% 64.67%
========================================
Files 925 925
Lines 35535 35538 +3
Branches 9130 9130
========================================
+ Hits 22978 22981 +3
Misses 12557 12557
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danjm
approved these changes
Mar 31, 2023
jpuri
approved these changes
Mar 31, 2023
DDDDDanica
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Instead of using the first NFT in the collection as the collection name, when no name is available, we should use "Unknown collection"
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.