[FLASK] Update snap delineator #18385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [430ecc2]
Page Load Metrics (1718 ± 65 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18385 +/- ##
========================================
Coverage 64.82% 64.82%
========================================
Files 930 931 +1
Lines 35763 35775 +12
Branches 9191 9199 +8
========================================
+ Hits 23181 23189 +8
- Misses 12582 12586 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Mrtenz
requested changes
Mar 31, 2023
GuillaumeRx
force-pushed
the
gr/update-snap-delineator
branch
from
fb0cc42 to
ba3911a
Compare
Mrtenz
previously approved these changes
Mar 31, 2023
NidhiKJha
reviewed
Mar 31, 2023
NidhiKJha
reviewed
Mar 31, 2023
Builds ready [9d40c64]
Page Load Metrics (1659 ± 94 ms)
Bundle size diffs
|
david0xd
previously approved these changes
Apr 3, 2023
eriknson
reviewed
Apr 3, 2023
| @@ -59,7 +60,7 @@ const SnapAuthorship = ({ snapId, className }) => { | |||
| paddingRight={4} | |||
| borderRadius={BorderRadius.pill} | |||
| display={DISPLAY.FLEX} | |||
| style={{ maxWidth: 'fit-content', width: '100%' }} | |||
| width={BLOCK_SIZES.FULL} | |||
| > | |||
| <Box> | |||
| <SnapAvatar snapId={snapId} /> | |||
There was a problem hiding this comment.
Out of scope for this PR, and also too small for its own issue, but could we add a fallback / background color (BackgroundColor.backgroundAlternative) to to take height for transparent avatar situations like attached.
(cc @FrederikBolding)
hmalik88
reviewed
Apr 3, 2023
hmalik88
reviewed
Apr 3, 2023
| paddingTop={1} | ||
| paddingRight={4} | ||
| paddingLeft={4} | ||
| paddingBottom={4} |
There was a problem hiding this comment.
same as above, merge please
There was a problem hiding this comment.
We cannot merge here, one of them is set to 1
hmalik88
reviewed
Apr 3, 2023
GuillaumeRx
force-pushed
the
gr/update-snap-delineator
branch
from
bea9f16 to
a42a588
Compare
Builds ready [a42a588]
Page Load Metrics (1701 ± 53 ms)
Bundle size diffs
|
hmalik88
approved these changes
Apr 3, 2023
david0xd
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This updates the Snap delineator per the figma designs linked in the issue.
It also contains a small fix to not limit the snap authorship component width (so it fits the under content width)
Screenshots/Screencaps
Manual Testing Steps
snap_dialog