Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix breaking jest test for MMI #18365

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Fix breaking jest test for MMI #18365

merged 3 commits into from
Mar 29, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

This snapshot is current broken on develop

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner March 29, 2023 15:22
@darkwing darkwing requested a review from hmalik88 March 29, 2023 15:22
vthomas13
vthomas13 previously approved these changes Mar 29, 2023
@mcmire
Copy link
Contributor

mcmire commented Mar 29, 2023

Looks like the minimum coverage thresholds needs to be bumped.

hmalik88
hmalik88 previously approved these changes Mar 29, 2023
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@PeterYinusa PeterYinusa dismissed stale reviews from hmalik88 and vthomas13 via 58f0e32 March 29, 2023 17:13
@metamaskbot
Copy link
Collaborator

Builds ready [58f0e32]
Page Load Metrics (1615 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89144113157
domContentLoaded13531793159011857
load13531890161513163
domInteractive13531793159011857
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #18365 (58f0e32) into develop (12bd9b0) will increase coverage by 0.03%.
The diff coverage is 90.91%.

@@             Coverage Diff             @@
##           develop   #18365      +/-   ##
===========================================
+ Coverage    64.64%   64.67%   +0.03%     
===========================================
  Files          920      923       +3     
  Lines        35473    35513      +40     
  Branches      9121     9132      +11     
===========================================
+ Hits         22929    22967      +38     
- Misses       12544    12546       +2     
Impacted Files Coverage Δ
ui/components/ui/qr-code/qr-code.js 78.57% <50.00%> (-2.20%) ⬇️
...compliance-feature-page/compliance-feature-page.js 88.89% <88.89%> (ø)
...utional/compliance-settings/compliance-settings.js 100.00% <100.00%> (ø)
...tichain/address-copy-button/address-copy-button.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hmalik88 hmalik88 merged commit 6052841 into develop Mar 29, 2023
@hmalik88 hmalik88 deleted the compliance-jest branch March 29, 2023 17:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants