Convert shared/modules/network.utils to TS #18352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
We want to convert NetworkController to TypeScript in order to be able to compare differences in the controller between in this repo and the core repo. To do this, however, we need to convert the dependencies of the controller to TypeScript. As a part of this effort, this commit converts `shared/modules/network.utils.js` to TypeScript, and also adds tests.
mcmire
force-pushed
the
convert-network-utils
branch
from
157eaf9 to
85cb577
Compare
8 tasks
Gudahtt
reviewed
Mar 29, 2023
Gudahtt
reviewed
Mar 29, 2023
Codecov Report
@@ Coverage Diff @@
## develop #18352 +/- ##
===========================================
+ Coverage 64.78% 64.80% +0.02%
===========================================
Files 927 927
Lines 35698 35684 -14
Branches 9164 9158 -6
===========================================
- Hits 23126 23123 -3
+ Misses 12572 12561 -11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Builds ready [4931a90]
Page Load Metrics (1554 ± 55 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Co-authored-by: Mark Stacey <[email protected]>
Builds ready [37da849]
Page Load Metrics (2071 ± 115 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Builds ready [23efe01]
Page Load Metrics (1750 ± 74 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brad-decker
approved these changes
Mar 31, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We want to convert NetworkController to TypeScript in order to be able to compare differences in the controller between in this repo and the core repo. To do this, however, we need to convert the dependencies of the controller to TypeScript.
As a part of this effort, this commit converts
shared/modules/network.utils.jsto TypeScript, and also adds tests.Progresses #18285.
Manual Testing Steps
This commit should not introduce any functional changes. All tests should pass, and all functionality in the extension should continue to work.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.