-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASK] Redesign key management modal #18263
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E2E tests seems to be broken due to a classname change
Builds ready [4fdd9c6]
Page Load Metrics (1623 ± 85 ms)
Bundle size diffs
|
Builds ready [9fc9d26]
Page Load Metrics (1773 ± 118 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18263 +/- ##
===========================================
- Coverage 64.64% 64.54% -0.10%
===========================================
Files 920 920
Lines 35473 35475 +2
Branches 9121 9124 +3
===========================================
- Hits 22929 22895 -34
- Misses 12544 12580 +36
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Builds ready [350d8ec]
Page Load Metrics (1639 ± 43 ms)
Bundle size diffs
|
Builds ready [9e61dfd]
Page Load Metrics (1575 ± 76 ms)
Bundle size diffs
|
Builds ready [423a81d]
Page Load Metrics (1691 ± 54 ms)
Bundle size diffs
|
Closes #18166
Updated the snap install warning modal to now house warnings for all weight-1 permissions, the design has also been updated per: https://www.figma.com/file/diidnCHx9FXj5LDiA5DZZr/Snaps-features?node-id=24-11653&t=IZlEBMh8N7M9QLjb-0
See below for new warning:
Screen.Recording.2023-03-21.at.3.54.14.PM.mov