Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Redesign key management modal #18263

Merged
merged 28 commits into from
Mar 29, 2023
Merged

Conversation

hmalik88
Copy link
Contributor

@hmalik88 hmalik88 commented Mar 21, 2023

Closes #18166

Updated the snap install warning modal to now house warnings for all weight-1 permissions, the design has also been updated per: https://www.figma.com/file/diidnCHx9FXj5LDiA5DZZr/Snaps-features?node-id=24-11653&t=IZlEBMh8N7M9QLjb-0

See below for new warning:

Screen.Recording.2023-03-21.at.3.54.14.PM.mov

@hmalik88 hmalik88 requested a review from a team as a code owner March 21, 2023 13:34
@hmalik88 hmalik88 requested a review from jpuri March 21, 2023 13:34
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Contributor

@GuillaumeRx GuillaumeRx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E2E tests seems to be broken due to a classname change

@metamaskbot
Copy link
Collaborator

Builds ready [4fdd9c6]
Page Load Metrics (1623 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002391263517
domContentLoaded14632059161917483
load14632059162317785
domInteractive14632059161917483
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [9fc9d26]
Page Load Metrics (1773 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint911911272612
domContentLoaded140121591758250120
load141321651773245118
domInteractive140121591758250120
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #18263 (dccd4ec) into develop (12bd9b0) will decrease coverage by 0.10%.
The diff coverage is 4.44%.

❗ Current head dccd4ec differs from pull request most recent head 423a81d. Consider uploading reports for the commit 423a81d to get more accurate results

@@             Coverage Diff             @@
##           develop   #18263      +/-   ##
===========================================
- Coverage    64.64%   64.54%   -0.10%     
===========================================
  Files          920      920              
  Lines        35473    35475       +2     
  Branches      9121     9124       +3     
===========================================
- Hits         22929    22895      -34     
- Misses       12544    12580      +36     
Impacted Files Coverage Δ
...unts-permissions/connected-accounts-permissions.js 0.00% <0.00%> (ø)
ui/helpers/utils/util.js 85.42% <0.00%> (ø)
ui/pages/permissions-connect/flask/util.js 0.00% <0.00%> (ø)
ui/helpers/utils/permission.js 5.43% <7.14%> (-0.38%) ⬇️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

GuillaumeRx
GuillaumeRx previously approved these changes Mar 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [350d8ec]
Page Load Metrics (1639 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint104156126136
domContentLoaded1475188516239043
load1475188516399043
domInteractive1475188516239043
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [9e61dfd]
Page Load Metrics (1575 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89143106126
domContentLoaded13841937155613263
load13842052157515876
domInteractive13841937155613263
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@hmalik88 hmalik88 merged commit c2b2f26 into develop Mar 29, 2023
@hmalik88 hmalik88 deleted the hm/redesign-key-management-modal branch March 29, 2023 19:18
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [423a81d]
Page Load Metrics (1691 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint911861242110
domContentLoaded14701938167612158
load14711938169111254
domInteractive14701938167612158
Bundle size diffs
  • background: 0 bytes
  • ui: 225 bytes
  • common: 0 bytes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement redesigned key management confirmation modal
4 participants