Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MMI] confirm-add-custodian-token component #18261

Merged
merged 20 commits into from
Mar 31, 2023
Merged

[MMI] confirm-add-custodian-token component #18261

merged 20 commits into from
Mar 31, 2023

Conversation

zone-live
Copy link
Contributor

Explanation

This PR adds the MMI ConfirmAddCustodianToken component under the ui/components/institutional/ folder.
Ref ticket: https://consensyssoftware.atlassian.net/browse/MMI-2653

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [adcf34c]
Page Load Metrics (1676 ± 84 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94175118178
domContentLoaded14362130166217082
load14552130167617684
domInteractive14362130166217082
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 21, 2023 •
edited
Loading

Codecov Report

Merging #18261 (3a02c04) into develop (9f89d71) will increase coverage by 0.03%.
The diff coverage is 80.28%.

@@             Coverage Diff             @@
##           develop   #18261      +/-   ##
===========================================
+ Coverage    64.67%   64.71%   +0.03%     
===========================================
  Files          924      925       +1     
  Lines        35490    35561      +71     
  Branches      9117     9139      +22     
===========================================
+ Hits         22953    23010      +57     
- Misses       12537    12551      +14
Impacted Files Coverage Δ
...ponents/institutional/jwt-url-form/jwt-url-form.js 72.73% <ø> (ø)
...add-custodian-token/confirm-add-custodian-token.js 80.00% <80.00%> (ø)
ui/helpers/constants/routes.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@zone-live zone-live marked this pull request as ready for review March 21, 2023 14:10
@zone-live zone-live requested a review from a team as a code owner March 21, 2023 14:10
@zone-live zone-live requested review from segun and NidhiKJha March 21, 2023 14:10
@zone-live zone-live requested a review from darkwing March 22, 2023 10:29
@metamaskbot
Copy link
Collaborator

Builds ready [5ecb4c0]
Page Load Metrics (1669 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1022211313416
domContentLoaded1507180616538440
load1507182316699646
domInteractive1507180616538440
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

brad-decker
brad-decker suggested changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@brad-decker brad-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review only. Will dive in more soon

ui/components/institutional/confirm-add-custodian-token/confirm-add-custodian-token.js Outdated Show resolved Hide resolved
ui/components/institutional/confirm-add-custodian-token/index.scss Outdated Show resolved Hide resolved
@zone-live zone-live requested a review from brad-decker March 22, 2023 15:12
@metamaskbot
Copy link
Collaborator

Builds ready [e083dbe]
Page Load Metrics (1586 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint942061172512
domContentLoaded1440172315678239
load1440176115869043
domInteractive1440172315678239
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

georgewrmarshall
georgewrmarshall reviewed Mar 22, 2023
View reviewed changes
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Made some suggestions

app/_locales/en/messages.json Outdated Show resolved Hide resolved
ui/pages/institutional/confirm-add-custodian-token/confirm-add-custodian-token.js Outdated Show resolved Hide resolved
ui/pages/institutional/confirm-add-custodian-token/confirm-add-custodian-token.js Outdated Show resolved Hide resolved
@zone-live zone-live dismissed a stale review via 9008559 March 23, 2023 10:14
@metamaskbot
Copy link
Collaborator

Builds ready [9008559]
Page Load Metrics (1521 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91147111168
domContentLoaded1379162015076833
load1379171515218541
domInteractive1379162015076833
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@zone-live zone-live dismissed a stale review via 4a8603d March 24, 2023 09:36
@albertolive albertolive dismissed stale reviews from ghost via 570f3e3 March 30, 2023 06:33
@zone-live zone-live dismissed a stale review via 7959311 March 30, 2023 14:18
@zone-live
Copy link
Contributor Author

Thank you for the help @georgewrmarshall 💪🏼

@zone-live zone-live dismissed a stale review via 9e04888 March 30, 2023 14:38
@zone-live zone-live dismissed a stale review via 3a02c04 March 30, 2023 14:50
@metamaskbot
Copy link
Collaborator

Builds ready [3a02c04]
Page Load Metrics (1530 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint86124103126
domContentLoaded1366178315159043
load1366178315309948
domInteractive1366178315159043
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@danjm danjm dismissed a stale review via 3a02c04 March 30, 2023 16:37
@pedronfigueiredo pedronfigueiredo dismissed a stale review via 3a02c04 March 30, 2023 17:33
@darkwing darkwing dismissed stale reviews from ghost via 3a02c04 March 30, 2023 18:11
@jpuri jpuri dismissed a stale review via 3a02c04 March 30, 2023 18:25
@mcmire mcmire dismissed stale reviews from ghost via 3a02c04 March 30, 2023 18:39
@danjm danjm dismissed a stale review via 3a02c04 March 30, 2023 20:03
@FrederikBolding FrederikBolding dismissed a stale review via 3a02c04 March 30, 2023 21:57
@mcmire mcmire dismissed a stale review via 3a02c04 March 30, 2023 22:49
@tmashuang tmashuang dismissed a stale review via 3a02c04 March 31, 2023 02:27
@DDDDDanica DDDDDanica dismissed a stale review via 3a02c04 March 31, 2023 09:00
@danjm danjm dismissed a stale review via 3a02c04 March 31, 2023 09:11
@albertolive albertolive merged commit 234fb4a into develop Mar 31, 2023
@albertolive albertolive deleted the MMI-2653-confirm-add-custodian-token branch March 31, 2023 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@georgewrmarshall georgewrmarshall georgewrmarshall left review comments

@brad-decker brad-decker brad-decker approved these changes

@albertolive albertolive albertolive approved these changes

@segun segun Awaiting requested review from segun segun is a code owner automatically assigned from MetaMask/extension-devs

@NidhiKJha NidhiKJha Awaiting requested review from NidhiKJha

@darkwing darkwing Awaiting requested review from darkwing

@coreyjanssen coreyjanssen Awaiting requested review from coreyjanssen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zone-live @metamaskbot @darkwing @albertolive @brad-decker @georgewrmarshall @coreyjanssen