Onboarding app header onboarding unit test and snapshot #18254

tmashuang · 2023-03-21T02:46:45Z

Explanation

Onboarding app header onboarding unit test and snapshot
Broken apart from #17360.
Partially completes #17191

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-03-21T02:46:58Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2023-03-21T02:54:37Z

Codecov Report

Merging #18254 (9d83b07) into develop (7390756) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #18254      +/-   ##
===========================================
+ Coverage    65.08%   65.10%   +0.02%     
===========================================
  Files          935      935              
  Lines        35924    35924              
  Branches      9228     9228              
===========================================
+ Hits         23378    23385       +7     
+ Misses       12546    12539       -7

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

metamaskbot · 2023-03-21T02:59:31Z

Builds ready [78bb08e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1584 ± 45 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	259	116	34	16
		domContentLoaded	1428	1795	1569	88	42
		load	1428	1795	1584	94	45
		domInteractive	1428	1795	1569	88	42

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-03-22T01:12:28Z

Builds ready [12e683d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1600 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	249	129	40	19
		domContentLoaded	1374	2169	1593	209	100
		load	1374	2169	1600	209	100
		domInteractive	1374	2169	1593	209	100

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-03-23T14:16:37Z

Builds ready [d0d4c6b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1663 ± 59 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	158	119	16	8
		domContentLoaded	1491	1990	1647	129	62
		load	1495	1991	1663	122	59
		domInteractive	1491	1990	1647	129	62

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-03-24T02:11:55Z

Builds ready [5033326]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1595 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	158	120	15	7
		domContentLoaded	1453	1832	1575	81	39
		load	1453	1833	1595	86	41
		domInteractive	1453	1832	1575	81	39

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-03-25T01:21:53Z

Builds ready [532b22c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1631 ± 86 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	172	123	19	9
		domContentLoaded	1455	2032	1616	165	79
		load	1455	2146	1631	180	86
		domInteractive	1455	2032	1616	165	79

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-03-28T13:56:46Z

Builds ready [393f223]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1644 ± 77 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	197	122	25	12
		domContentLoaded	1489	2001	1624	128	62
		load	1490	2211	1644	160	77
		domInteractive	1489	2001	1624	128	62

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-03-30T03:32:07Z

Builds ready [3aca18a]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1522 ± 34 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	135	109	10	5
		domContentLoaded	1415	1627	1514	65	31
		load	1416	1666	1522	71	34
		domInteractive	1415	1627	1514	65	31

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

ui/pages/onboarding-flow/onboarding-app-header/onboarding-app-header.test.js

…p-header

metamaskbot · 2023-03-31T03:27:56Z

Builds ready [b5399dd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1825 ± 115 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	200	127	23	11
		domContentLoaded	1458	2226	1803	230	110
		load	1524	2305	1825	239	115
		domInteractive	1458	2226	1803	230	110

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-04-01T00:48:21Z

Builds ready [9cee1ed]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1531 ± 38 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	271	116	37	18
		domContentLoaded	1401	1749	1511	86	41
		load	1409	1749	1531	78	38
		domInteractive	1401	1749	1511	86	41

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

…p-header

metamaskbot · 2023-04-05T02:58:52Z

Builds ready [9d83b07]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2294 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	110	341	188	47	23
		domContentLoaded	1915	2558	2265	173	83
		load	1939	2572	2294	177	85
		domInteractive	1915	2558	2265	173	83

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

Onboarding app header onboarding unit test and snapshot

78bb08e

tmashuang requested a review from a team as a code owner March 21, 2023 02:46

tmashuang requested a review from hmalik88 March 21, 2023 02:46

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

12e683d

…p-header

darkwing approved these changes Mar 22, 2023

View reviewed changes

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

d0d4c6b

…p-header

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

5033326

…p-header

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

532b22c

…p-header

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

393f223

…p-header

tmashuang added 2 commits March 29, 2023 17:29

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

c9002bd

…p-header

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

3aca18a

…p-header

DDDDDanica reviewed Mar 30, 2023

View reviewed changes

ui/pages/onboarding-flow/onboarding-app-header/onboarding-app-header.test.js Show resolved Hide resolved

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

b5399dd

…p-header

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

9cee1ed

…p-header

DDDDDanica approved these changes Apr 3, 2023

View reviewed changes

tmashuang added 2 commits April 4, 2023 07:55

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

d57f3b2

…p-header

Merge branch 'develop' into 17191-onboarding-unit-tests-onboarding-ap…

9d83b07

…p-header

tmashuang merged commit 3a38140 into develop Apr 5, 2023

tmashuang deleted the 17191-onboarding-unit-tests-onboarding-app-header branch April 5, 2023 02:59

github-actions bot locked and limited conversation to collaborators Apr 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Onboarding app header onboarding unit test and snapshot #18254

Onboarding app header onboarding unit test and snapshot #18254

tmashuang commented Mar 21, 2023

github-actions bot commented Mar 21, 2023

codecov bot commented Mar 21, 2023 •

edited

Loading

metamaskbot commented Mar 21, 2023

metamaskbot commented Mar 22, 2023

metamaskbot commented Mar 23, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 25, 2023

metamaskbot commented Mar 28, 2023

metamaskbot commented Mar 30, 2023

metamaskbot commented Mar 31, 2023

metamaskbot commented Apr 1, 2023

metamaskbot commented Apr 5, 2023

Onboarding app header onboarding unit test and snapshot #18254

Onboarding app header onboarding unit test and snapshot #18254

Conversation

tmashuang commented Mar 21, 2023

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 21, 2023

codecov bot commented Mar 21, 2023 • edited Loading

Codecov Report

metamaskbot commented Mar 21, 2023

metamaskbot commented Mar 22, 2023

metamaskbot commented Mar 23, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 25, 2023

metamaskbot commented Mar 28, 2023

metamaskbot commented Mar 30, 2023

metamaskbot commented Mar 31, 2023

metamaskbot commented Apr 1, 2023

metamaskbot commented Apr 5, 2023

codecov bot commented Mar 21, 2023 •

edited

Loading