IPFS unit test for onboarding privacy setting #18252

tmashuang · 2023-03-21T02:45:52Z

Explanation

IPFS unit test for onboarding privacy setting
Broken apart from #17360.
Partially completes #17191

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-03-21T02:46:05Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-03-21T03:22:25Z

Builds ready [d71e092]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1587 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	146	118	15	7
		domContentLoaded	1413	2059	1560	142	68
		load	1423	2168	1587	168	81
		domInteractive	1413	2059	1560	142	68

Bundle size diffs

background: 0 bytes
ui: 40 bytes
common: 0 bytes

codecov · 2023-03-21T03:22:36Z

Codecov Report

Merging #18252 (1e6d9f8) into develop (06fba70) will increase coverage by 0.06%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #18252      +/-   ##
===========================================
+ Coverage    64.66%   64.72%   +0.06%     
===========================================
  Files          923      923              
  Lines        35480    35480              
  Branches      9115     9115              
===========================================
+ Hits         22942    22963      +21     
+ Misses       12538    12517      -21

Impacted Files	Coverage Δ
...boarding-flow/privacy-settings/privacy-settings.js	`84.62% <ø> (+28.85%)`	⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

metamaskbot · 2023-03-22T01:05:58Z

Builds ready [68f8a89]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1446 ± 24 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	133	107	10	5
		domContentLoaded	1376	1573	1445	46	22
		load	1376	1595	1446	49	24
		domInteractive	1376	1573	1445	46	22

Bundle size diffs

background: 0 bytes
ui: 40 bytes
common: 0 bytes

metamaskbot · 2023-03-23T14:18:54Z

Builds ready [88656dd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1755 ± 269 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	94	481	159	108	52
		domContentLoaded	1415	3143	1743	546	262
		load	1415	3143	1755	559	269
		domInteractive	1415	3143	1743	546	262

Bundle size diffs

background: 0 bytes
ui: 40 bytes
common: 0 bytes

metamaskbot · 2023-03-24T01:13:08Z

Builds ready [dffb941]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1555 ± 33 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	136	113	14	7
		domContentLoaded	1451	1661	1543	53	25
		load	1452	1719	1555	70	33
		domInteractive	1451	1661	1543	53	25

Bundle size diffs

background: 0 bytes
ui: 40 bytes
common: 0 bytes

metamaskbot · 2023-03-25T01:38:09Z

Builds ready [dcc6e0d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1790 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	258	138	34	16
		domContentLoaded	1393	2333	1773	236	113
		load	1394	2352	1790	236	113
		domInteractive	1393	2333	1773	236	113

Bundle size diffs

background: 0 bytes
ui: 40 bytes
common: 0 bytes

metamaskbot · 2023-03-28T14:13:42Z

Builds ready [34fff92]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1713 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	182	121	19	9
		domContentLoaded	1445	1971	1687	139	67
		load	1445	1975	1713	162	78
		domInteractive	1445	1971	1687	139	67

Bundle size diffs

background: 0 bytes
ui: 40 bytes
common: 0 bytes

metamaskbot · 2023-03-30T03:23:43Z

Builds ready [1e6d9f8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1883 ± 81 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	109	190	138	19	9
		domContentLoaded	1629	2148	1855	165	79
		load	1652	2250	1883	168	81
		domInteractive	1629	2148	1855	165	79

Bundle size diffs

background: 0 bytes
ui: 40 bytes
common: 0 bytes

IPFS unit test for onboarding privacy setting

d71e092

tmashuang requested a review from a team as a code owner March 21, 2023 02:45

tmashuang requested a review from adonesky1 March 21, 2023 02:45

Merge branch 'develop' into 17191-onboarding-unit-tests-privacy-settings

68f8a89

darkwing approved these changes Mar 22, 2023

View reviewed changes

Merge branch 'develop' into 17191-onboarding-unit-tests-privacy-settings

88656dd

Merge branch 'develop' into 17191-onboarding-unit-tests-privacy-settings

dffb941

Merge branch 'develop' into 17191-onboarding-unit-tests-privacy-settings

dcc6e0d

Merge branch 'develop' into 17191-onboarding-unit-tests-privacy-settings

34fff92

tmashuang added 2 commits March 29, 2023 17:29

Merge branch 'develop' into 17191-onboarding-unit-tests-privacy-settings

81f4621

Merge branch 'develop' into 17191-onboarding-unit-tests-privacy-settings

1e6d9f8

DDDDDanica approved these changes Mar 30, 2023

View reviewed changes

tmashuang merged commit 00e6471 into develop Mar 31, 2023

tmashuang deleted the 17191-onboarding-unit-tests-privacy-settings branch March 31, 2023 02:27

github-actions bot locked and limited conversation to collaborators Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

IPFS unit test for onboarding privacy setting #18252

IPFS unit test for onboarding privacy setting #18252

tmashuang commented Mar 21, 2023

github-actions bot commented Mar 21, 2023

metamaskbot commented Mar 21, 2023

codecov bot commented Mar 21, 2023 •

edited

Loading

metamaskbot commented Mar 22, 2023

metamaskbot commented Mar 23, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 25, 2023

metamaskbot commented Mar 28, 2023

metamaskbot commented Mar 30, 2023

IPFS unit test for onboarding privacy setting #18252

IPFS unit test for onboarding privacy setting #18252

Conversation

tmashuang commented Mar 21, 2023

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 21, 2023

metamaskbot commented Mar 21, 2023

codecov bot commented Mar 21, 2023 • edited Loading

Codecov Report

metamaskbot commented Mar 22, 2023

metamaskbot commented Mar 23, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 25, 2023

metamaskbot commented Mar 28, 2023

metamaskbot commented Mar 30, 2023

codecov bot commented Mar 21, 2023 •

edited

Loading