Welcome onboarding unit test #18248

tmashuang · 2023-03-21T02:42:49Z

Explanation

Welcome onboarding unit test
Broken apart from #17360.
Partially completes #17191

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-03-21T02:43:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-03-21T03:09:15Z

Builds ready [c0368e7]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1812 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	108	165	133	19	9
		domContentLoaded	1447	2082	1778	160	77
		load	1448	2164	1812	174	83
		domInteractive	1447	2082	1778	160	77

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

codecov · 2023-03-21T03:09:25Z

Codecov Report

Merging #18248 (337dec0) into develop (6be1855) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #18248      +/-   ##
===========================================
+ Coverage    64.55%   64.58%   +0.03%     
===========================================
  Files          920      920              
  Lines        35469    35469              
  Branches      9121     9121              
===========================================
+ Hits         22895    22905      +10     
+ Misses       12574    12564      -10

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

metamaskbot · 2023-03-22T01:06:41Z

Builds ready [5647beb]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1551 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	150	112	17	8
		domContentLoaded	1350	1952	1535	154	74
		load	1368	1952	1551	147	71
		domInteractive	1350	1952	1535	154	74

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-23T14:21:18Z

Builds ready [679ea8b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1599 ± 52 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	156	116	17	8
		domContentLoaded	1422	1772	1565	90	43
		load	1422	1809	1599	108	52
		domInteractive	1422	1772	1565	90	43

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-24T02:04:31Z

Builds ready [be9a847]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1624 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	138	114	10	5
		domContentLoaded	1396	1963	1607	135	65
		load	1396	1963	1624	144	69
		domInteractive	1396	1963	1607	135	65

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-25T01:23:50Z

Builds ready [1e9778f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1619 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	228	117	29	14
		domContentLoaded	1397	1869	1600	131	63
		load	1398	1869	1619	131	63
		domInteractive	1397	1869	1600	131	63

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-28T13:56:13Z

Builds ready [d25302c]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1595 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	197	126	28	14
		domContentLoaded	1443	1789	1590	86	41
		load	1479	1789	1595	80	39
		domInteractive	1443	1789	1590	86	41

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-29T04:58:24Z

Builds ready [337dec0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1658 ± 70 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	148	114	13	6
		domContentLoaded	1441	1864	1628	113	54
		load	1441	1975	1658	146	70
		domInteractive	1441	1864	1628	113	54

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

Welcome onboarding unit test

c0368e7

tmashuang requested a review from a team as a code owner March 21, 2023 02:42

tmashuang requested a review from chloeYue March 21, 2023 02:42

Merge branch 'develop' into 17191-onboarding-unit-tests-welcome

5647beb

darkwing approved these changes Mar 22, 2023

View reviewed changes

Merge branch 'develop' into 17191-onboarding-unit-tests-welcome

679ea8b

Merge branch 'develop' into 17191-onboarding-unit-tests-welcome

be9a847

Merge branch 'develop' into 17191-onboarding-unit-tests-welcome

1e9778f

Merge branch 'develop' into 17191-onboarding-unit-tests-welcome

d25302c

DDDDDanica approved these changes Mar 28, 2023

View reviewed changes

Merge branch 'develop' into 17191-onboarding-unit-tests-welcome

337dec0

tmashuang merged commit 8f65c26 into develop Mar 29, 2023

tmashuang deleted the 17191-onboarding-unit-tests-welcome branch March 29, 2023 06:00

github-actions bot locked and limited conversation to collaborators Mar 29, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Welcome onboarding unit test #18248

Welcome onboarding unit test #18248

tmashuang commented Mar 21, 2023 •

edited

Loading

github-actions bot commented Mar 21, 2023

metamaskbot commented Mar 21, 2023

codecov bot commented Mar 21, 2023 •

edited

Loading

metamaskbot commented Mar 22, 2023

metamaskbot commented Mar 23, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 25, 2023

metamaskbot commented Mar 28, 2023

metamaskbot commented Mar 29, 2023

Welcome onboarding unit test #18248

Welcome onboarding unit test #18248

Conversation

tmashuang commented Mar 21, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 21, 2023

metamaskbot commented Mar 21, 2023

codecov bot commented Mar 21, 2023 • edited Loading

Codecov Report

metamaskbot commented Mar 22, 2023

metamaskbot commented Mar 23, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 25, 2023

metamaskbot commented Mar 28, 2023

metamaskbot commented Mar 29, 2023

tmashuang commented Mar 21, 2023 •

edited

Loading

codecov bot commented Mar 21, 2023 •

edited

Loading