Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed text for review spending cap copy #18214

Merged
merged 3 commits into from
Mar 21, 2023

Conversation

aleksandar-mihajlovic
Copy link
Contributor

Explanation

Changed text for review spending cap copy instead of Review your spending cap it now shows Review the spending cap for your.

Screenshot

Before

Screenshot 2023-03-17 at 11 41 55

After

Screenshot 2023-03-17 at 11 27 06

Unit tests

Screenshot 2023-03-17 at 11 35 41

Lint

Screenshot 2023-03-17 at 11 28 35

Manual Testing Steps

  1. Login to MetaMask extension
  2. Go to https://metamask.github.io/test-dapp/
  3. Click Create Token
  4. Click Confirm in MetaMask extension and wait transaction to be done
  5. Go to https://metamask.github.io/test-dapp/
  6. Click Approve Tokens
  7. Put some value in input and click Next
  8. Now the screen has title Review the spending cap for your

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [d3e6048]
Page Load Metrics (1807 ± 101 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint901811312311
domContentLoaded146923441778208100
load146923621807210101
domInteractive146923441778208100
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@dzfjz
Copy link
Contributor

dzfjz commented Mar 17, 2023

Verified by QA

@aleksandar-mihajlovic aleksandar-mihajlovic marked this pull request as ready for review March 17, 2023 12:59
@aleksandar-mihajlovic aleksandar-mihajlovic requested a review from a team as a code owner March 17, 2023 12:59
Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • Checked copy matches ticket
  • Checked instances of "Review your spending cap" both have been updated
    Screenshot 2023-03-18 at 10 14 26 AM

@metamaskbot
Copy link
Collaborator

Builds ready [f115319]
Page Load Metrics (1579 ± 38 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94150122178
domContentLoaded1412176115678240
load1412176115797938
domInteractive1412176115678240
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #18214 (f115319) into develop (33a25cd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #18214   +/-   ##
========================================
  Coverage    63.96%   63.96%           
========================================
  Files          914      914           
  Lines        35621    35621           
  Branches      9028     9028           
========================================
  Hits         22783    22783           
  Misses       12838    12838           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aleksandar-mihajlovic aleksandar-mihajlovic merged commit a854cfd into develop Mar 21, 2023
@aleksandar-mihajlovic aleksandar-mihajlovic deleted the review-spenging-cap-copy-fix branch March 21, 2023 11:39
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix review spending cap copy
5 participants