ci: disable prep-build-desktop in circleci

[legobeat]

Context

some flakiness here; from develop:

https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/39653/workflows/b78f1bc9-f3ff-4de4-9d7d-cf47f245dc57/jobs/1091593

Considering Desktop is no longer a focus so is it worth keeping the tests? This removes desktop building from the circleci pipeline.

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[codecov]

Codecov Report

Merging #18187 (0364cb0) into develop (de4cf0a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #18187      +/-   ##
===========================================
- Coverage    64.37%   64.37%   -0.01%     
===========================================
  Files          909      909              
  Lines        35267    35267              
  Branches      9014     9014              
===========================================
- Hits         22703    22701       -2     
- Misses       12564    12566       +2     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[legobeat]

CI test-deps-audit error addressed separately in #18208

[Gudahtt]

Makes sense! I don't think we need this build since the desktop integration functionality has been added to Flask.

[rekmarks]

TBD if we're doing this.

[cryptotavares]

@legobeat the flakiness does not seem to be related with the desktop build type. But rather with the build process (see circle insights). There's a success rate of 98-99% for the prep-build-desktop (which is in line with any other prep-build-<BUILD_TYPE>)

Moreover the Desktop app uses the desktop build type to build the Extension code used there (we are importing the Extension as submodule).

• main process build - see this
• renderer process bundling - see this

So If it is possible, we would like to keep this CI jobs for the desktop build type.