[FLASK] Update UI related to MetaMask Snaps Platform trademark #18172

david0xd · 2023-03-15T16:23:12Z

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/358

Explanation

This PR is following the text and design updates following the requests from https://github.com/MetaMask/MetaMask-planning/issues/358.

Only trademark update is required on a Settings page for Snaps. Other places are matching the rule explained in https://github.com/MetaMask/MetaMask-planning/issues/358.

https://github.com/MetaMask/MetaMask-planning/issues/358 was also requesting better design of the top two lines of text on the Snaps list, but these are removed according to the new design proposal for this page which should go after this work is done: MetaMask/snaps#1170 (https://www.figma.com/file/diidnCHx9FXj5LDiA5DZZr/Snaps-features?node-id=55-11895&t=i31mw6uZ1dow4i0h-0).

Screenshots/Screencaps

Before

After

Manual Testing Steps

Open MetaMask extension popup or fullscreen view.
Go to the Settings > Snaps.
Install or remove Snap depending on which part is tested.

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

github-actions · 2023-03-15T16:23:26Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-03-16T13:57:23Z

Builds ready [f24abe1]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1702 ± 54 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	399	138	63	30
		domContentLoaded	1484	1897	1692	112	54
		load	1504	1897	1702	112	54
		domInteractive	1484	1897	1692	112	54

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

codecov · 2023-03-16T13:57:30Z

Codecov Report

Merging #18172 (b141536) into develop (a854cfd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #18172   +/-   ##
========================================
  Coverage    64.19%   64.19%           
========================================
  Files          908      908           
  Lines        35211    35211           
  Branches      8989     8989           
========================================
  Hits         22601    22601           
  Misses       12610    12610

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ui/pages/settings/flask/snaps-list-tab/snap-list-tab.js

metamaskbot · 2023-03-16T15:54:30Z

Builds ready [45f2e1e]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1698 ± 68 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	217	131	28	13
		domContentLoaded	1476	2040	1685	151	72
		load	1484	2040	1698	141	68
		domInteractive	1476	2040	1685	151	72

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

metamaskbot · 2023-03-16T17:35:46Z

Builds ready [ae60875]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1495 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	167	113	20	10
		domContentLoaded	1244	1779	1487	122	59
		load	1244	1779	1495	130	63
		domInteractive	1244	1779	1487	122	59

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

rekmarks

We should use "MetaMask Snaps" to refer to the platform. We should try to avoid using those words to refer to snaps collectively.

eriknson · 2023-03-20T12:48:39Z

New design: https://www.figma.com/file/diidnCHx9FXj5LDiA5DZZr/Snaps-features?node-id=621%3A34030&t=4axfyXOGXshsOMdO-1

metamaskbot · 2023-03-20T21:43:13Z

Builds ready [7f7e9b6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1702 ± 60 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	268	127	35	17
		domContentLoaded	1538	1904	1682	104	50
		load	1538	2023	1702	125	60
		domInteractive	1538	1904	1682	104	50

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

rekmarks

LGTM!

metamaskbot · 2023-03-21T12:37:45Z

Builds ready [b141536]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2073 ± 153 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	285	165	44	21
		domContentLoaded	1573	2574	2040	308	148
		load	1583	2606	2073	319	153
		domInteractive	1573	2574	2040	308	148

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

david0xd self-assigned this Mar 15, 2023

david0xd force-pushed the dd/update-snaps-trademark branch from 1d6b179 to 6140f2d Compare March 16, 2023 11:44

FrederikBolding reviewed Mar 16, 2023

View reviewed changes

ui/pages/settings/flask/snaps-list-tab/snap-list-tab.js Outdated Show resolved Hide resolved

david0xd force-pushed the dd/update-snaps-trademark branch from dcf6549 to ae60875 Compare March 16, 2023 17:03

david0xd marked this pull request as ready for review March 16, 2023 17:30

david0xd requested a review from a team as a code owner March 16, 2023 17:30

david0xd requested a review from danjm March 16, 2023 17:30

rekmarks requested changes Mar 16, 2023

View reviewed changes

david0xd force-pushed the dd/update-snaps-trademark branch from 359e8a6 to 7f7e9b6 Compare March 20, 2023 21:18

rekmarks previously approved these changes Mar 21, 2023

View reviewed changes

david0xd dismissed rekmarks’s stale review via 8596057 March 21, 2023 12:12

david0xd and others added 12 commits March 21, 2023 13:13

Update UI related to MetaMask Snaps Platform trademark

2013ce9

Remove redundant UI text according to new designs

b22796d

Fix lint errors

3db63fa

Fix e2e test expectation

8c01f7c

Fix lint in test

1c58102

Fix e2e test expectation

a1df02c

Fix some UI parts

5b3200b

Update CSS for noSnaps message

cb30d49

Add next design iteration

f48bd51

Add minor fix

4b36205

Update locale message

f7af0a8

Fix learn more text size

76b7817

Refactor usage of design system components

b141536

david0xd force-pushed the dd/update-snaps-trademark branch from 8596057 to b141536 Compare March 21, 2023 12:13

FrederikBolding approved these changes Mar 21, 2023

View reviewed changes

rekmarks approved these changes Mar 21, 2023

View reviewed changes

david0xd merged commit 0847917 into develop Mar 21, 2023

david0xd deleted the dd/update-snaps-trademark branch March 21, 2023 15:52

github-actions bot locked and limited conversation to collaborators Mar 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLASK] Update UI related to MetaMask Snaps Platform trademark #18172

[FLASK] Update UI related to MetaMask Snaps Platform trademark #18172

david0xd commented Mar 15, 2023 •

edited

Loading

github-actions bot commented Mar 15, 2023

metamaskbot commented Mar 16, 2023

codecov bot commented Mar 16, 2023 •

edited

Loading

metamaskbot commented Mar 16, 2023

metamaskbot commented Mar 16, 2023

rekmarks left a comment

eriknson commented Mar 20, 2023

metamaskbot commented Mar 20, 2023

rekmarks left a comment

metamaskbot commented Mar 21, 2023

[FLASK] Update UI related to MetaMask Snaps Platform trademark #18172

[FLASK] Update UI related to MetaMask Snaps Platform trademark #18172

Conversation

david0xd commented Mar 15, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Mar 15, 2023

metamaskbot commented Mar 16, 2023

codecov bot commented Mar 16, 2023 • edited Loading

Codecov Report

metamaskbot commented Mar 16, 2023

metamaskbot commented Mar 16, 2023

rekmarks left a comment

Choose a reason for hiding this comment

eriknson commented Mar 20, 2023

metamaskbot commented Mar 20, 2023

rekmarks left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 21, 2023

david0xd commented Mar 15, 2023 •

edited

Loading

codecov bot commented Mar 16, 2023 •

edited

Loading