Revert "What's new - OpenSea security provider (#16831)" #17968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vthomas13
force-pushed
the
932282e-reversion
branch
2 times, most recently
from
acec49d to
9a47093
Compare
Builds ready [fd64e13]
Page Load Metrics (1766 ± 112 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov Report
@@ Coverage Diff @@
## develop #17968 +/- ##
===========================================
- Coverage 64.12% 63.48% -0.63%
===========================================
Files 912 902 -10
Lines 35535 35239 -296
Branches 9013 8914 -99
===========================================
- Hits 22784 22371 -413
- Misses 12751 12868 +117
... and 95 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Builds ready [5bbe620]
Page Load Metrics (1543 ± 66 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
danjm
previously requested changes
Mar 9, 2023
There was a problem hiding this comment.
@vthomas13 Why were the verify locale fix commits needed? Is there a reason we just can't do the single revert commit?
vthomas13
force-pushed
the
932282e-reversion
branch
2 times, most recently
from
37f0bc4 to
e6f0609
Compare
darkwing
previously approved these changes
Mar 16, 2023
NidhiKJha
previously approved these changes
Mar 16, 2023
vthomas13
force-pushed
the
932282e-reversion
branch
from
e6f0609 to
e9feea7
Compare
Builds ready [e9feea7]
Page Load Metrics (1550 ± 41 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
NidhiKJha
approved these changes
Mar 16, 2023
This reverts commit 932282e.
vthomas13
force-pushed
the
932282e-reversion
branch
from
ab73ac8 to
69407ae
Compare
danjm
approved these changes
Mar 22, 2023
Builds ready [69407ae]
Page Load Metrics (1555 ± 40 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 932282e.
Explanation
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.