[MMI] Added code fencing in info tab component #17910

albertolive · 2023-02-27T11:22:26Z

Explanation

Added code fencing in info tab component

https://consensyssoftware.atlassian.net/browse/MMI-2514

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue

github-actions · 2023-02-27T11:22:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-03-01T14:15:30Z

Builds ready [d5c1160]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1727 ± 80 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	191	137	22	10
		domContentLoaded	1402	2073	1716	166	80
		load	1402	2073	1727	167	80
		domInteractive	1402	2073	1716	166	80

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

NidhiKJha

Question: Are we updating the links for privacy and site url from metamask to mmi??

Current behaviour:

Screen.Recording.2023-03-20.at.4.55.53.PM.mov

Changed

Screen.Recording.2023-03-20.at.4.55.02.PM.mov

albertolive · 2023-03-20T13:24:26Z

Hi @NidhiKJha,

Good catch! I tried the same thing, and the link has indeed changed. But it doesn't make sense because I'm adding code fencing. Will the code fencing be applied correctly when the builds are generated? Or am I missing something else?

metamaskbot · 2023-03-20T15:16:18Z

Builds ready [7b07df6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1977 ± 146 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	417	167	68	33
		domContentLoaded	1438	2351	1959	309	148
		load	1456	2417	1977	305	146
		domInteractive	1438	2351	1959	309	148

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

codecov · 2023-03-20T15:16:33Z

Codecov Report

Merging #17910 (8dc3e2d) into develop (234fb4a) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop   #17910      +/-   ##
===========================================
- Coverage    64.78%   64.78%   -0.01%     
===========================================
  Files          926      926              
  Lines        35666    35670       +4     
  Branches      9159     9159              
===========================================
  Hits         23106    23106              
- Misses       12560    12564       +4

Impacted Files	Coverage Δ
ui/pages/settings/info-tab/info-tab.component.js	`3.57% <0.00%> (-0.60%)`	⬇️
ui/helpers/constants/common.ts	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

albertolive · 2023-03-24T13:39:54Z

@NidhiKJha can you test it again? Have made some changes :)

….com/MetaMask/metamask-extension into feature/MMI-2514-update-the-info-tab

metamaskbot · 2023-03-24T14:11:31Z

Builds ready [aff92c6]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1654 ± 91 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	148	113	15	7
		domContentLoaded	1431	2046	1627	161	77
		load	1431	2213	1654	190	91
		domInteractive	1431	2046	1627	161	77

Bundle size diffs

background: 0 bytes
ui: 70 bytes
common: 0 bytes

metamaskbot · 2023-03-28T12:47:25Z

Builds ready [fab541b]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1499 ± 26 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	152	105	16	8
		domContentLoaded	1430	1600	1489	42	20
		load	1430	1643	1499	54	26
		domInteractive	1430	1600	1489	42	20

Bundle size diffs

background: 0 bytes
ui: 70 bytes
common: 0 bytes

NidhiKJha

Checked storybook with links. LGTM

metamaskbot · 2023-03-31T09:55:28Z

Builds ready [8dc3e2d]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1562 ± 50 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	299	116	43	21
		domContentLoaded	1415	1703	1543	88	42
		load	1416	1774	1562	104	50
		domInteractive	1415	1703	1543	88	42

Bundle size diffs

background: 0 bytes
ui: 70 bytes
common: 0 bytes

Added code fencing in info tab component

9013bad

albertolive requested review from zone-live and shane-t February 27, 2023 11:23

Merge branch 'develop' into feature/MMI-2514-update-the-info-tab

d5c1160

albertolive marked this pull request as ready for review March 1, 2023 14:31

albertolive requested a review from a team as a code owner March 1, 2023 14:31

albertolive requested a review from mcmire March 1, 2023 14:31

zone-live previously approved these changes Mar 1, 2023

View reviewed changes

albertolive requested a review from brad-decker March 6, 2023 09:59

NidhiKJha reviewed Mar 20, 2023

View reviewed changes

Merge branch 'develop' into feature/MMI-2514-update-the-info-tab

7b07df6

Fixed storybook urls

5214e00

albertolive dismissed zone-live’s stale review via 5214e00 March 24, 2023 13:36

Merge branch 'develop' into feature/MMI-2514-update-the-info-tab

a3b95bc

albertolive added 2 commits March 24, 2023 14:46

Removed isBeta mmi code fencing

9322030

Merge branch 'feature/MMI-2514-update-the-info-tab' of https://github…

aff92c6

….com/MetaMask/metamask-extension into feature/MMI-2514-update-the-info-tab

Merge branch 'develop' into feature/MMI-2514-update-the-info-tab

fab541b

NidhiKJha approved these changes Mar 31, 2023

View reviewed changes

albertolive added 2 commits March 31, 2023 11:22

Merge branch 'develop' into feature/MMI-2514-update-the-info-tab

0571249

Merge branch 'develop' into feature/MMI-2514-update-the-info-tab

8dc3e2d

zone-live approved these changes Mar 31, 2023

View reviewed changes

albertolive merged commit c261817 into develop Mar 31, 2023

albertolive deleted the feature/MMI-2514-update-the-info-tab branch March 31, 2023 11:23

github-actions bot locked and limited conversation to collaborators Mar 31, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MMI] Added code fencing in info tab component #17910

[MMI] Added code fencing in info tab component #17910

albertolive commented Feb 27, 2023

github-actions bot commented Feb 27, 2023

metamaskbot commented Mar 1, 2023

NidhiKJha left a comment

albertolive commented Mar 20, 2023 •

edited

Loading

metamaskbot commented Mar 20, 2023

codecov bot commented Mar 20, 2023 •

edited

Loading

albertolive commented Mar 24, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 28, 2023

NidhiKJha left a comment

metamaskbot commented Mar 31, 2023

[MMI] Added code fencing in info tab component #17910

[MMI] Added code fencing in info tab component #17910

Conversation

albertolive commented Feb 27, 2023

Explanation

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Feb 27, 2023

metamaskbot commented Mar 1, 2023

NidhiKJha left a comment

Choose a reason for hiding this comment

Current behaviour:

Changed

albertolive commented Mar 20, 2023 • edited Loading

metamaskbot commented Mar 20, 2023

codecov bot commented Mar 20, 2023 • edited Loading

Codecov Report

albertolive commented Mar 24, 2023

metamaskbot commented Mar 24, 2023

metamaskbot commented Mar 28, 2023

NidhiKJha left a comment

Choose a reason for hiding this comment

metamaskbot commented Mar 31, 2023

albertolive commented Mar 20, 2023 •

edited

Loading

codecov bot commented Mar 20, 2023 •

edited

Loading