-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the ConsenSys zkEVM (Linea) as a default network #17875
feat: add the ConsenSys zkEVM (Linea) as a default network #17875
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @VGau, this is looking good from a UI perspective. Do you know if #234FD5
is the brand color for Consensys? We could add this too our design tokens and replace it so consensys zkevm has it's own color and doesn't need to use the Goerli color
Hey @VGau, I was wondering instead of using color we could add these images for test networks?? I think it's a lot more scalable |
Yes sure ! I will add these images. Should I add these images in the networks dropdown too ? 😄 |
d37ac5d
to
ceb2d63
Compare
Codecov Report
@@ Coverage Diff @@
## develop #17875 +/- ##
===========================================
- Coverage 64.19% 64.15% -0.04%
===========================================
Files 908 908
Lines 35211 35256 +45
Branches 8989 9006 +17
===========================================
+ Hits 22601 22617 +16
- Misses 12610 12639 +29
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6ff785b
to
2c44b0e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -4,6 +4,8 @@ | |||
--mainnet: #29b6af; | |||
--inherit: inherit; | |||
--transparent: transparent; | |||
--color-network-linea-testnet-default: #000000; | |||
--color-network-linea-testnet-inverse: #fcfcfc; | |||
// DO NOT CHANGE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to other reviewers: Usually we wouldn't allow static hex values but I think we can refactor the test networks to use images like other token icons during the multichain v0.5 work so this will be temporary.
2c44b0e
to
f99cf8a
Compare
I believe there is a requirement that this network not be shown until March 28. Can you add some logic to the network dropdown and the settings sections to ensure that is the case. roughly something like:
And use that to conditionally render the network in the dropdown and in the network settings pages |
7bf78e7
to
b9457fa
Compare
c6dade4
to
b765608
Compare
this branch probably needs to be updated to latest develop to avoid the |
98f6535
to
4a63413
Compare
4a63413
to
9b30ce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me
Explanation
The goal of the PR is to add the ConsenSys zkEVM network (Linea) as a default test network like Goerli and Sepolia.
I've updated all translation files.
This change can only be tested when this PR (MetaMask/design-tokens#408) is merged and the new design tokens library version is updated on metamask-extension repo.
Screenshots/Screencaps
Before
After
Manual Testing Steps
Step 1:
Go to the metamask home screen and select Goerli test network in the dropdown.
Step 2:
Go to this website: https://bridge.goerli.zkevm.consensys.net/send?token=ETH and send some ETH (minimum 0.1) from Goerli to Consensys zkEVM .
Wait for transaction to be finished.
Step 3:
Go to the metamask home screen and select then new ConsenSys zkEVM test network in the dropdown.
Step 4:
Go to this website: https://bridge.goerli.zkevm.consensys.net/send?token=ETH and send some ETH (minimum 0.1) from Consensys zkEVM to Goerli.
Wait for transaction to be finished.
Final step:
Check if all transactions succeed on Metamask.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.