Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add double arrow icons #17654

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Conversation

garrettbear
Copy link
Contributor

Explanation

Add double arrow icons << & >>

*Fixes #17367

Screenshots/Screencaps

Before

n/a

After

Screenshot 2023-02-07 at 2 49 42 PM

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b9e8e74]
Page Load Metrics (1234 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint941811272512
domContentLoaded95616711215241116
load95617301234251121
domInteractive95616711215241116

@codecov-commenter
Copy link

Codecov Report

Merging #17654 (b9e8e74) into develop (8298369) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           develop   #17654   +/-   ##
========================================
  Coverage    61.64%   61.64%           
========================================
  Files          910      910           
  Lines        35085    35085           
  Branches      8888     8888           
========================================
  Hits         21628    21628           
  Misses       13457    13457           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on svg optimization 🦾 LGTM!

@NidhiKJha NidhiKJha merged commit 661b592 into develop Feb 8, 2023
@NidhiKJha NidhiKJha deleted the feat/17367/add-double-arrow-icons branch February 8, 2023 07:40
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "<<" and ">>" icons
6 participants